Add support for expiring acknowledgements #391
Commits on Aug 16, 2022
-
Add support for expiring acknowledgements naemon#302
Parts of this code were based on work done in Icinga v1 by Ricardo Bartels for Icinga/icinga-core#369. Closes naemon#302. Signed-off-by: Roel van Meer <[email protected]>
-
Add command definitions for expiring acknowledgements
Signed-off-by: Roel van Meer <[email protected]>
-
Add end_time argument to acknowledge_*_problem functions
Signed-off-by: Roel van Meer <[email protected]>
-
Signed-off-by: Roel van Meer <[email protected]>
Commits on Sep 7, 2022
-
Support end_time in the broker
Signed-off-by: Roel van Meer <[email protected]>
-
Set acknowledgement_end_time in host and service structs
Signed-off-by: Roel van Meer <[email protected]>
-
Ensure host and service comments know about expiry
Signed-off-by: Roel van Meer <[email protected]>
-
Ensure acknowledgement_end_time is set (or cleared)
Signed-off-by: Roel van Meer <[email protected]>
-
Read and write acknowledgement_end_time in retention data
Signed-off-by: Roel van Meer <[email protected]>
-
Create and handle host ack expire event
Signed-off-by: Roel van Meer <[email protected]>
-
Reschedule events when starting
If neamon starts and the retention data contains expiring acks that still need to happen, ensure the expire events are properly scheduled. Signed-off-by: Roel van Meer <[email protected]>
-
Add tests for ACKNOWLEDGE_HOST_PROBLEM_EXPIRE
Signed-off-by: Roel van Meer <[email protected]>
-
-
Separate clearing and destroying event queue
In tests, we want to be able to remove all events but not destroy the queue.
-
Properly remove references to events when destroying
After destroying the check events, references to those events must be cleared. If not, scheduling a new check event will try to destroy the event that is still referenced, which causes a segfault.
-
-
Add test for expiring acknowledgement
This adds a test that checks if the acknowledgement expiry event does its work. It starts by removing all events from the event queue. We then run the command, with expiration set in two seconds. After waiting three seconds, we process a single event (we should have only one event in the queue at this point). After processing the event, the acknowledgement should be gone.
