suppress only normal notifications from service parents #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes service parents work more like service dependencies. Previously service parents simply dropped all notifications which leads to some issues: - if a service goes down, sends a notification but comes up before the parent, no recover will be sent - forced notifications, downtimes etc won't send a notification With this change only "normal" notifications will be suppressed if all parents are down. But the following notifications will still be sent: - custom notifications - acknowlegements - flapping alerts - downtime alerts Signed-off-by: Sven Nierlein <[email protected]>
nook24
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes service parents work more like service dependencies. Previously service parents simply dropped all notifications which leads to some issues:
With this change only "normal" notifications will be suppressed if all parents are down. But the following notifications will still be sent: