Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowkey Vault Docker does not support dynamic host ports #1320

Merged
merged 1 commit into from
Jan 18, 2025

Conversation

nagyesta
Copy link
Owner

@nagyesta nagyesta commented Jan 17, 2025

Issue: #1319

Description

  • Adds new configuration option to allow relaxed matching of vault URI ports
  • Updates tests
  • Deprecates Testcontainers method setting a fixed host port
  • Enhances Testcontainers module to always use the relaxed matching feature
  • Adds more verification steps to Testcontainers tests
  • Updates documentation

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

@nagyesta nagyesta added the enhancement New feature or request label Jan 17, 2025
@nagyesta nagyesta self-assigned this Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.89%. Comparing base (3155588) to head (e45fab1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1320   +/-   ##
=========================================
  Coverage     98.89%   98.89%           
- Complexity     2032     2034    +2     
=========================================
  Files           239      239           
  Lines          4965     4976   +11     
  Branches        196      197    +1     
=========================================
+ Hits           4910     4921   +11     
  Misses           42       42           
  Partials         13       13           
Flag Coverage Δ
app 99.37% <100.00%> (+<0.01%) ⬆️
client 94.00% <ø> (ø)
testcontainers 96.05% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- Adds new configuration option to allow relaxed matching of vault URI ports
- Updates tests
- Deprecates Testcontainers method setting a fixed host port
- Enhances Testcontainers module to always use the relaxed matching feature
- Adds more verification steps to Testcontainers tests
- Updates documentation

Updates #1319
{minor}

Signed-off-by: Esta Nagy <[email protected]>
@nagyesta nagyesta force-pushed the feature/1319-support-dynamic-ports branch from 6aeb2e7 to e45fab1 Compare January 18, 2025 07:51
@nagyesta nagyesta merged commit 23c7b26 into main Jan 18, 2025
13 checks passed
@nagyesta nagyesta deleted the feature/1319-support-dynamic-ports branch January 18, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant