Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Docker Image for multiple Architectures #1324

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

nagyesta
Copy link
Owner

Issue: #1270

Description

  • Update readme files to mention multi-arch images more prominently
  • Implement new check in the LowkeyVaultContainer to recommend multi-arch images when it could be beneficial
  • Add new tests

Entry point

Checklists

  • I have rebased my branch
  • My commit message is meaningful
  • The commit messages use semantic versioning: {major}, {minor} or {patch}
  • The changes are focusing on the issue at hand
  • I have maintained or increased test coverage

Notes

@nagyesta nagyesta added the enhancement New feature or request label Jan 21, 2025
- Update readme files to mention multi-arch images more prominently
- Implement new check in the LowkeyVaultContainer to recommend multi-arch images when it could be beneficial
- Add new tests

Updates #1270
{minor}

Signed-off-by: Esta Nagy <[email protected]>
@nagyesta nagyesta force-pushed the feature/1270-multi-arch-support branch from 0808f0d to 303e7a4 Compare January 21, 2025 22:02
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.83%. Comparing base (72f6e8a) to head (303e7a4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...wkeyvault/testcontainers/LowkeyVaultContainer.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1324      +/-   ##
============================================
- Coverage     98.85%   98.83%   -0.02%     
- Complexity     2036     2041       +5     
============================================
  Files           239      239              
  Lines          4982     4994      +12     
  Branches        198      201       +3     
============================================
+ Hits           4925     4936      +11     
  Misses           43       43              
- Partials         14       15       +1     
Flag Coverage Δ
app 99.32% <ø> (ø)
client 94.00% <ø> (ø)
testcontainers 95.81% <92.30%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nagyesta nagyesta merged commit 6a770d2 into main Jan 21, 2025
12 of 13 checks passed
@nagyesta nagyesta deleted the feature/1270-multi-arch-support branch January 21, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant