-
Notifications
You must be signed in to change notification settings - Fork 1
[feat] add login and signup modal #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
β¨ feat: add authlayout component and implement responsive design β»οΈ refactor: rename layout file update login page structure and modify package-lock.json
This reverts commit bcc9109.
devmanta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
λ§‘μμ λΆλΆ λλ΅μ μΌλ‘ κ΅΄λ¬λ κ°κ² ꡬνμλ£λμλ€μ!!
κ³ μνμ
¨μ΅λλ€~~!! πππ
μΈλΌμΈ μ€νμΌ λΉΌλκ±°λ μ€κ°μ μν°κ° νλ μλ€μ΄κ°λλ° μλΆλΆ κ³ μ³μ£Όμλ©΄ μ’μκ²κ°μ΅λλ€!
| type="submit" | ||
| disabled={!isValid || !!errors.termsAccepted} | ||
| className={isValid ? '' : styles.disabled} | ||
| style={{ height: '40px' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ΄κ²λ μΈλΌμΈμ νμ§λ§κ³ cssνμΌλ‘ μ²λ¦¬νμΌλ©΄ μ’κ² μ΄μ!
| } | ||
| .linkContainer { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ¬μ΄ μν°...μ΄λ μλκΉ...γ γ γ γ
| const successMessage = 'κ°μ μ΄ μλ£λμμ΅λλ€!'; | ||
| openModal(successMessage, 'success'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
λ³μ λ°λ‘ μ μΈμν΄μ£Όκ³ μΈλΌμΈμΌλ‘ λ°λ‘ μ¨λ μ’μκ²κ°λ€μ!
| const successMessage = 'κ°μ μ΄ μλ£λμμ΅λλ€!'; | |
| openModal(successMessage, 'success'); | |
| openModal( 'κ°μ μ΄ μλ£λμμ΅λλ€!', 'success'); |
| } = useForm<SignupFormInputs>({ mode: 'onChange' }); | ||
| const router = useRouter(); | ||
|
|
||
| const watchPassword = watch('password'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
watchλ μ²μλ΄μ μ κΉ μ°Ύμλ΄€λλ° watchλ useWatch λκ°λ₯Ό react hook formμμ μ 곡ν΄μ£Όλκ±Έλ‘ κ²μμ΄λλ€μ
useWatchλ₯Ό μ°μ§ μκ³ watchλ₯Ό μ°μ μ΄μ κ°μμκΉμ?
(μ€λͺ
λ§ λ³΄λ©΄ useWatch μ°λκ² λ λλ§μ΄ λν΄μ μ±λ₯μ μ΄μ μ΄ μλκ² κ°μμ μ§λ¬Έλ립λλ€!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
κ°λ¨ν μ¬μ©ν λλ watchλ₯Ό μ¬μ©ν΄λ λλ€κ³ λ΄κ°μ§κ΅¬ μ¨λ΄£μ΅λλ€ γ γ
najitwo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
| padding: 20px; | ||
| border-radius: 8px; | ||
| box-shadow: 0 2px 10px rgba(0, 0, 0, 0.1); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enter π
| <div style={{ display: 'flex', justifyContent: 'center' }}> | ||
| <p> | ||
| νμμ΄ μλμ κ°μ?{' '} | ||
| <span | ||
| style={{ | ||
| color: 'var(--violet)', | ||
| textDecoration: 'underline', | ||
| cursor: 'pointer', | ||
| }} | ||
| onClick={() => router.push('/signup')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μΈλΌμΈ μ€νμΌμ΄ λ§λ€μ~
κΌ νμνμ§ μμΌλ©΄ μΈλΌμΈ μ€νμΌμ μ§μν΄μ£ΌμΈμ~
| </div> | ||
| <Button | ||
| type="submit" | ||
| disabled={!isValid || !!errors.termsAccepted} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!!errors.termsAccepted μλ μ μλ건κ°μ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μ΄ν΄λ³΄λ λΆνμνλ€μ μ§μ°κ²μ΅λλΉ
| {...register('email', { | ||
| required: ERROR_MESSAGES.EMAIL_REQUIRE, | ||
| pattern: { | ||
| value: /^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$/, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μμλ‘ μλΉΌλ λλμ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
μμλ‘λΉΌμ μλ‘ μμ±ν΄λκ²μ΅λλΉ
* [feat] implement toast message (#117) * β¨ feat: implement toast message * π fix: resolve lint error * β¨ feat: apply toast notifications * β‘οΈ refactor: improve toast * π·οΈ chore: update type * [feat] add modal for adding columns (#119) * β¨ feat: add create column modal * β¨ feat: add create column modal * :chore: fix styling and type * β¨ feat: add delete and update column modal * π fix: resolve lint error * π fix: resolve lint error * β»οΈ refactor: reflect to review * π fix: resolve build error * [feat] dashboard restore (#122) * π fix: null check for assignee * π style: check assignee exist * β¨ feat: set dashboard to null if deleted * β¨ feat: add toast message after update or delete * β»οΈ refactor: refetch dashboards if data is changed and add toast msg * β°οΈ remove: remove dead code * π style: skeleton linear effect * π style: add no wrap for card column label * π style: remove button outline * π style: add z-index on header dropdown menu * π style: responsivce css * π style: modal height * β»οΈ refactor: remove header my menu if ouside clicked * [refactor] refetch card data once card is created, deleted, updated (#124) * β»οΈ refactor: trigger store add card * β»οΈ refactor: refetch card data once create,update,delete * β¨ feat: redirect to mydashboard if token is existed * [feat] add login and signup modal (#118) * π₯ remove: styled components β¨ feat: add authlayout component and implement responsive design β»οΈ refactor: rename layout file update login page structure and modify package-lock.json * β¨ feat: add signup page and css * π fix: type error * β»οΈ refactor: signup page css and move api folder * βοΈ feat: add login signup modal * π fix: install js-cookie * Revert "π fix: install js-cookie" This reverts commit bcc9109. * β»οΈ refactor: css structure and finalize styles * [fix] manage multiple cards in card store (#126) * π fix: manage multiple cards in card store * π fix: prevent duplicate cards and clear cards on dashboard navigation * π fix: push to index after logout (#128) * [style] improve dashboard uiux (#129) * π style: add min height to create column button * π style: improve UI/UX * π fix build error * π fix build error * π fix build error * π© style: update min-width for responsive design * π© style: update for responsive design * [fix] redirection for non token (#130) * π fix: redirection for non token * π fix: get total count on header members * βοΈ fix: typo * π remove: console * π fix: logout router replace * π fix: resolve delete column error (#132) --------- Co-authored-by: naji <[email protected]> Co-authored-by: κΉμ§μ€ <[email protected]> Co-authored-by: λμΉμ½ <[email protected]>
π Related Issue
π Description