Skip to content

Conversation

@naseungyeop
Copy link
Collaborator

@naseungyeop naseungyeop commented Nov 29, 2024

πŸ“Œ Related Issue

#109

πŸ“ Description

  • λͺ¨λ‹¬μ„ μΆ”κ°€ν–‡μŠ΅λ‹ˆλ‹€

@naseungyeop naseungyeop self-assigned this Nov 29, 2024
@devmanta devmanta added the ✨Feature Request for a new feature or functionality label Nov 29, 2024
Copy link
Collaborator

@devmanta devmanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맑은신 λΆ€λΆ„ λŒ€λž΅μ μœΌλ‘œ κ΅΄λŸ¬λŠ” κ°€κ²Œ κ΅¬ν˜„μ™„λ£Œλ˜μ—ˆλ„€μš”!!
κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€~~!! πŸ‘πŸ‘πŸ‘
인라인 μŠ€νƒ€μΌ λΉΌλŠ”κ±°λž‘ 쀑간에 μ—”ν„°κ°€ ν•˜λ‚˜ μ•ˆλ“€μ–΄κ°”λŠ”λ° μš”λΆ€λΆ„ κ³ μ³μ£Όμ‹œλ©΄ μ’‹μ„κ²ƒκ°™μŠ΅λ‹ˆλ‹€!

type="submit"
disabled={!isValid || !!errors.termsAccepted}
className={isValid ? '' : styles.disabled}
style={{ height: '40px' }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이것두 인라인에 ν•˜μ§€λ§κ³  css파일둜 μ²˜λ¦¬ν–ˆμœΌλ©΄ μ’‹κ² μ–΄μš”!

Comment on lines 69 to 70
}
.linkContainer {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

사이 μ—”ν„°...μ–΄λ– μ‹­λ‹ˆκΉŒ...γ…Žγ…Žγ…Žγ…Ž

Comment on lines 39 to 40
const successMessage = 'κ°€μž…μ΄ μ™„λ£Œλ˜μ—ˆμŠ΅λ‹ˆλ‹€!';
openModal(successMessage, 'success');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ³€μˆ˜ λ”°λ‘œ μ„ μ–Έμ•ˆν•΄μ£Όκ³  인라인으둜 λ°”λ‘œ 써도 μ’‹μ„κ²ƒκ°™λ„€μš”!

Suggested change
const successMessage = 'κ°€μž…μ΄ μ™„λ£Œλ˜μ—ˆμŠ΅λ‹ˆλ‹€!';
openModal(successMessage, 'success');
openModal( 'κ°€μž…μ΄ μ™„λ£Œλ˜μ—ˆμŠ΅λ‹ˆλ‹€!', 'success');

} = useForm<SignupFormInputs>({ mode: 'onChange' });
const router = useRouter();

const watchPassword = watch('password');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watchλŠ” μ²˜μŒλ΄μ„œ 잠깐 μ°Ύμ•„λ΄€λŠ”λ° watchλž‘ useWatch λ‘κ°œλ₯Ό react hook formμ—μ„œ μ œκ³΅ν•΄μ£ΌλŠ”κ±Έλ‘œ κ²€μƒ‰μ΄λ˜λ„€μš”
useWatchλ₯Ό μ“°μ§€ μ•Šκ³  watchλ₯Ό μ“°μ‹ μ΄μœ κ°€μžˆμ„κΉŒμš”?
(μ„€λͺ…λ§Œ 보면 useWatch μ“°λŠ”κ²Œ λ Œλ”λ§μ΄ λœν•΄μ„œ μ„±λŠ₯상 이점이 μžˆλŠ”κ²ƒ κ°™μ•„μ„œ μ§ˆλ¬Έλ“œλ¦½λ‹ˆλ‹€!)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ°„λ‹¨νžˆ μ‚¬μš©ν• λ•ŒλŠ” watchλ₯Ό μ‚¬μš©ν•΄λ„ λœλ‹€κ³  봐가지ꡬ μ¨λ΄£μŠ΅λ‹ˆλ‹€ γ…Žγ…Ž

Copy link
Owner

@najitwo najitwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

padding: 20px;
border-radius: 8px;
box-shadow: 0 2px 10px rgba(0, 0, 0, 0.1);
}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enter πŸ˜‡

Comment on lines 107 to 116
<div style={{ display: 'flex', justifyContent: 'center' }}>
<p>
νšŒμ›μ΄ μ•„λ‹ˆμ‹ κ°€μš”?{' '}
<span
style={{
color: 'var(--violet)',
textDecoration: 'underline',
cursor: 'pointer',
}}
onClick={() => router.push('/signup')}
Copy link
Owner

@najitwo najitwo Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인라인 μŠ€νƒ€μΌμ΄ λ§Žλ„€μš”~
κΌ­ ν•„μš”ν•˜μ§€ μ•ŠμœΌλ©΄ 인라인 μŠ€νƒ€μΌμ€ μ§€μ–‘ν•΄μ£Όμ„Έμš”~

</div>
<Button
type="submit"
disabled={!isValid || !!errors.termsAccepted}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!!errors.termsAccepted μ–˜λŠ” μ™œ μžˆλŠ”κ±΄κ°€μš”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ‚΄νŽ΄λ³΄λ‹ˆ λΆˆν•„μš”ν•˜λ„€μš” μ§€μš°κ²ŸμŠ΅λ‹ˆλ‹Ή

{...register('email', {
required: ERROR_MESSAGES.EMAIL_REQUIRE,
pattern: {
value: /^[a-zA-Z0-9._%+-]+@[a-zA-Z0-9.-]+\.[a-zA-Z]{2,}$/,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μƒμˆ˜λ‘œ μ•ˆλΉΌλ„ λ˜λ‚˜μš”?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μƒμˆ˜λ‘œλΉΌμ„œ μƒˆλ‘œ μž‘μ„±ν•΄λ‘κ²ŸμŠ΅λ‹ˆλ‹Ή

@naseungyeop naseungyeop merged commit 900644c into develop Dec 1, 2024
1 check passed
ghost pushed a commit that referenced this pull request Dec 1, 2024
* [feat] implement toast message (#117)

* ✨ feat: implement toast message

* πŸ› fix: resolve lint error

* ✨ feat: apply toast notifications

* ⚑️ refactor: improve toast

* 🏷️ chore: update type

* [feat] add modal for adding columns (#119)

* ✨ feat: add create column modal

* ✨ feat: add create column modal

* :chore: fix styling and type

* ✨ feat: add delete and update column modal

* πŸ› fix: resolve lint error

* πŸ› fix: resolve lint error

* ♻️ refactor: reflect to review

* πŸ› fix: resolve build error

* [feat] dashboard restore  (#122)

* πŸ› fix: null check for assignee

* πŸ’„ style: check assignee exist

* ✨ feat: set dashboard to null if deleted

* ✨ feat: add toast message after update or delete

* ♻️ refactor: refetch dashboards if data is changed and add toast msg

* ⚰️ remove: remove dead code

* πŸ’„ style: skeleton linear effect

* πŸ’„ style: add no wrap for card column label

* πŸ’„ style: remove button outline

* πŸ’„ style: add z-index on header dropdown menu

* πŸ’„ style: responsivce css

* πŸ’„ style: modal height

* ♻️ refactor: remove header my menu if ouside clicked

* [refactor] refetch card data once card is created, deleted, updated (#124)

* ♻️ refactor: trigger store add card

* ♻️ refactor: refetch card data once create,update,delete

* ✨ feat: redirect to mydashboard if token is existed

* [feat] add login and signup modal (#118)

* πŸ”₯ remove: styled components

✨ feat: add authlayout component and implement responsive
design

♻️ refactor: rename layout file update login page structure and modify package-lock.json

* ✨ feat: add signup page and css

* πŸ› fix: type error

* ♻️ refactor: signup page css and move api folder

* ❇️ feat: add login signup modal

* πŸ› fix: install js-cookie

* Revert "πŸ› fix: install js-cookie"

This reverts commit bcc9109.

* ♻️ refactor: css structure and finalize styles

* [fix] manage multiple cards in card store (#126)

* πŸ› fix: manage multiple cards in card store

* πŸ› fix: prevent duplicate cards and clear cards on dashboard navigation

* πŸ› fix: push to index after logout (#128)

* [style] improve dashboard uiux (#129)

* πŸ’„ style: add min height to create column button

* πŸ’„ style: improve UI/UX

* πŸ› fix build error

* πŸ› fix build error

* πŸ› fix build error

* πŸ’© style: update min-width for responsive design

* πŸ’© style: update for responsive design

* [fix] redirection for non token (#130)

* πŸ› fix: redirection for non token

* πŸ› fix: get total count on header members

* ✏️ fix: typo

* πŸ”‡ remove: console

* πŸ› fix: logout router replace

* πŸ› fix: resolve delete column error (#132)

---------

Co-authored-by: naji <[email protected]>
Co-authored-by: κΉ€μ§€μœ€ <[email protected]>
Co-authored-by: λ‚˜μŠΉμ—½ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨Feature Request for a new feature or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants