Skip to content

Conversation

@devmanta
Copy link
Collaborator

@devmanta devmanta commented Nov 30, 2024

๐Ÿ“Œ Related Issue

close #112

๐Ÿ“ Description

  • ์งœ์ž˜ํ•˜๊ฒŒ ๊ฑธ๋ฆฌ์ ๋Œ€๋Š” ๋ฐ˜์‘ํ˜• css ์ˆ˜์ •
  • ๋Œ€์‹œ๋ณด๋“œ ๋ฐ์ดํ„ฐ ์ˆ˜์ •/์‚ญ์ œ์‹œ ์‚ฌ์ด๋“œ๋ฐ” ์ƒˆ๋กœ๊ณ ์นจ
  • ํ• ์ผ์กฐํšŒ์—์„œ ๋‹ด๋‹น์ž์—†์œผ๋ฉด ํ•ด๋‹น์—ญ์—ญ ์•ˆ๊ทธ๋ฆฌ๊ธฐ
  • ํ† ์ŠคํŠธ๋ฉ”์„ธ์ง€ ์ถ”๊ฐ€
  • ํ—ค๋” ๋‚ด์ •๋ณด ์Šค์ผˆ๋ ˆํ†ค์— ๊นจ์•Œ ์ขŒ์šฐ ๋ฐ˜์ง์ž„? ์ดํŒฉํŠธํšจ๊ณผ ์ถ”๊ฐ€ (์Šค๋กœํ‹€๋ง์œผ๋กœ ๋ณด๋ฉด ํ™”๊ธด๊ฐ€๋Šฅ..ใ…Ž)

๐Ÿ“ธ Screenshot

image

@devmanta devmanta self-assigned this Nov 30, 2024
@devmanta devmanta added the ๐Ÿ”จRefactor Code refactoring tasks to improve code structure and maintainability without changing functionality label Nov 30, 2024
setValue={setValue}
defaultAssignee={
members?.filter((member) => member.userId == card?.assignee.id)[0]
members?.filter((member) => member.userId == card?.assignee?.id)[0]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹ด๋‹น์ž์—†์„๋•Œ ์ˆ˜์ •๋ˆ„๋ฅด๋ฉด ์—๋Ÿฌ๋‚˜์„œ ์ถ”๊ฐ€ํ–ˆ์Šด๋‹ค

});

useEffect(() => {
refetch();
Copy link
Collaborator Author

@devmanta devmanta Nov 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑด useDashboards์—์„œ ๊ฐ€์ ธ๋‹ค์“ฐ๋Š” useApi๊ฐ€ ๊ตฌ์กฐ์ ์œผ๋กœ ๋ฌธ์ œ?๊ฐ€์žˆ์–ด์„œ (useApi ๋ถˆ๋Ÿฌ์˜ค๋ฉด ๋ฐ”๋กœapi๋ฅผ ๋จผ์ € ์จ)
์ตœ์ดˆ๋ Œ๋”๋ง๋ ๋•Œ 2๋ฒˆํ˜ธ์ถœํ•˜๋Š” ์ด์Šˆ ์žˆ์Šต๋‹ˆ๋‹ค^.^

duration = 2000,
showButton = true,
theme = 'dark'
theme = 'light'
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ €ํฌ ๋Œ€์‹œ๋ณด๋“œ ํŽ˜์ด์ง€๊ฐ€ ์ „์ฒด์ ์œผ๋กœ light ํ…Œ๋งˆ์—ฌ์„œ ๊ธฐ๋ณธ๊ฐ’ ๋ผ์ดํŠธ๋กœ ๋ฐ”๊ฟ”์คฌ์Šต๋‹ˆ๋‹ค..!

.container {
max-height: 580px;
min-width: 330px;
overflow-y: auto;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ ‡๊ฒŒํ•˜๋‹ˆ๊น ๋Œ“๊ธ€์ชฝ overflow๋ž‘ ๊ฒน์ณ์„œ ๋ญ”๊ฐ€ ๋‚ด๋ง˜๋Œ€๋กœ ์•ˆ๋˜๊ธดํ•œ๋ฐ ์ผ๋‹จ ์ด๋Ÿฌ์ผ€ ๋’€์–ด์š”..

rgba(255, 255, 255, 0.6) 50%,
rgba(255, 255, 255, 0.2) 100%
);
animation: shine 1.5s infinite;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

โ˜€

Copy link
Owner

@najitwo najitwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

refetch ์ „์ฒด์ ์œผ๋กœ ๋‹ค ์ ์šฉํ•˜์‹ ๊ฑด๊ฐ€์š”???
๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค. ๐Ÿ‘๐Ÿ‘

@devmanta
Copy link
Collaborator Author

devmanta commented Nov 30, 2024

refetch ์ „์ฒด์ ์œผ๋กœ ๋‹ค ์ ์šฉํ•˜์‹ ๊ฑด๊ฐ€์š”??? ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค. ๐Ÿ‘๐Ÿ‘

@najitwo
๋Œ€์‹œ๋ณด๋“œ์ชฝ ์ˆ˜์ •/์ƒ์„ฑ/์‚ญ์ œ๋Š” ๋‹ค ์ ์šฉํ–ˆ์–ด์š”!
์ด๋ ‡๊ฒŒ ํ•˜๋Š”๊ฑฐ ๊ฐ ์ฐฎ์€์ง€ ์ผ๋‹จ pr์˜ฌ๋ ค๋ดค๊ตฌ
๋งˆ์ง€๋ง‰์œผ๋กœ ์นด๋“œ์ชฝ ํ•ด์•ผํ•˜์ง€ ์•Š์„๊นŒ ์‹ถ์Šต๋‹ˆ๋‹ค..ใ…Žใ…Žใ…Ž

@devmanta devmanta merged commit fa9be3e into develop Nov 30, 2024
1 check passed
@devmanta devmanta deleted the 112-dashboard-restore branch November 30, 2024 13:20
ghost pushed a commit that referenced this pull request Dec 1, 2024
* [feat] implement toast message (#117)

* โœจ feat: implement toast message

* ๐Ÿ› fix: resolve lint error

* โœจ feat: apply toast notifications

* โšก๏ธ refactor: improve toast

* ๐Ÿท๏ธ chore: update type

* [feat] add modal for adding columns (#119)

* โœจ feat: add create column modal

* โœจ feat: add create column modal

* :chore: fix styling and type

* โœจ feat: add delete and update column modal

* ๐Ÿ› fix: resolve lint error

* ๐Ÿ› fix: resolve lint error

* โ™ป๏ธ refactor: reflect to review

* ๐Ÿ› fix: resolve build error

* [feat] dashboard restore  (#122)

* ๐Ÿ› fix: null check for assignee

* ๐Ÿ’„ style: check assignee exist

* โœจ feat: set dashboard to null if deleted

* โœจ feat: add toast message after update or delete

* โ™ป๏ธ refactor: refetch dashboards if data is changed and add toast msg

* โšฐ๏ธ remove: remove dead code

* ๐Ÿ’„ style: skeleton linear effect

* ๐Ÿ’„ style: add no wrap for card column label

* ๐Ÿ’„ style: remove button outline

* ๐Ÿ’„ style: add z-index on header dropdown menu

* ๐Ÿ’„ style: responsivce css

* ๐Ÿ’„ style: modal height

* โ™ป๏ธ refactor: remove header my menu if ouside clicked

* [refactor] refetch card data once card is created, deleted, updated (#124)

* โ™ป๏ธ refactor: trigger store add card

* โ™ป๏ธ refactor: refetch card data once create,update,delete

* โœจ feat: redirect to mydashboard if token is existed

* [feat] add login and signup modal (#118)

* ๐Ÿ”ฅ remove: styled components

โœจ feat: add authlayout component and implement responsive
design

โ™ป๏ธ refactor: rename layout file update login page structure and modify package-lock.json

* โœจ feat: add signup page and css

* ๐Ÿ› fix: type error

* โ™ป๏ธ refactor: signup page css and move api folder

* โ‡๏ธ feat: add login signup modal

* ๐Ÿ› fix: install js-cookie

* Revert "๐Ÿ› fix: install js-cookie"

This reverts commit bcc9109.

* โ™ป๏ธ refactor: css structure and finalize styles

* [fix] manage multiple cards in card store (#126)

* ๐Ÿ› fix: manage multiple cards in card store

* ๐Ÿ› fix: prevent duplicate cards and clear cards on dashboard navigation

* ๐Ÿ› fix: push to index after logout (#128)

* [style] improve dashboard uiux (#129)

* ๐Ÿ’„ style: add min height to create column button

* ๐Ÿ’„ style: improve UI/UX

* ๐Ÿ› fix build error

* ๐Ÿ› fix build error

* ๐Ÿ› fix build error

* ๐Ÿ’ฉ style: update min-width for responsive design

* ๐Ÿ’ฉ style: update for responsive design

* [fix] redirection for non token (#130)

* ๐Ÿ› fix: redirection for non token

* ๐Ÿ› fix: get total count on header members

* โœ๏ธ fix: typo

* ๐Ÿ”‡ remove: console

* ๐Ÿ› fix: logout router replace

* ๐Ÿ› fix: resolve delete column error (#132)

---------

Co-authored-by: naji <[email protected]>
Co-authored-by: ๊น€์ง€์œค <[email protected]>
Co-authored-by: ๋‚˜์Šน์—ฝ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

๐Ÿ”จRefactor Code refactoring tasks to improve code structure and maintainability without changing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] refetch dashboard once create, delete, update is called

3 participants