[style] improve dashboard uiux #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
π¨HTML&CSS
ghost
self-assigned this
4 tasks
devmanta
approved these changes
Dec 1, 2024
Collaborator
devmanta
left a comment
devmanta
left a comment
There was a problem hiding this comment.
κ³ μνμ ¨μ΅λλ€~
Comment on lines
+113
to
+117
| style={{ | ||
| backgroundColor: snapshot.isDraggingOver | ||
| ? 'var(--violet-light)' | ||
| : '', | ||
| }} |
Collaborator
There was a problem hiding this comment.
μ΄κ±° λ€μμλ μΈλΌμΈμμ°κ³ ν΄λμ€λ‘ λ°λ‘ μ²λ¦¬ν μ μμκ²κ°μ΅λλ€
| export default function PrimarySection({ inView }: Props) { | ||
| return ( | ||
| <section className={styles.section}> | ||
| <section id="secondary" className={styles.section}> |
Collaborator
There was a problem hiding this comment.
γ γ γ idκ° λ°λκ±°κ°μμ secondary sectionμ primaryλ£κ³ μ¬κΈ°λ PrimarySectionμΈμ μΈμ»¨λ리..?
Comment on lines
+11
to
+21
| useEffect(() => { | ||
| const handleScroll = () => { | ||
| setScroll(window.scrollY); | ||
| }; | ||
|
|
||
| window.addEventListener('scroll', handleScroll); | ||
|
|
||
| return () => { | ||
| window.removeEventListener('scroll', handleScroll); | ||
| }; | ||
| }, []); |
Collaborator
There was a problem hiding this comment.
μλ μ νμνμΉκ΅¬μμ ?
λλ©νμ΄μ§λ ν΄λΌμ΄μΈνΈμ¬μ΄λλ λλ§ μνκ³
ssrλ‘ μ μ©ν΄μΌ seoλ λκ³ λλ¨Έμ§ ssrμ₯μ μ μ΅λν νμ©ν μ μλ νμ΄μ§μΌκ²κ°μμ
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Dec 1, 2024
* [feat] implement toast message (#117) * β¨ feat: implement toast message * π fix: resolve lint error * β¨ feat: apply toast notifications * β‘οΈ refactor: improve toast * π·οΈ chore: update type * [feat] add modal for adding columns (#119) * β¨ feat: add create column modal * β¨ feat: add create column modal * :chore: fix styling and type * β¨ feat: add delete and update column modal * π fix: resolve lint error * π fix: resolve lint error * β»οΈ refactor: reflect to review * π fix: resolve build error * [feat] dashboard restore (#122) * π fix: null check for assignee * π style: check assignee exist * β¨ feat: set dashboard to null if deleted * β¨ feat: add toast message after update or delete * β»οΈ refactor: refetch dashboards if data is changed and add toast msg * β°οΈ remove: remove dead code * π style: skeleton linear effect * π style: add no wrap for card column label * π style: remove button outline * π style: add z-index on header dropdown menu * π style: responsivce css * π style: modal height * β»οΈ refactor: remove header my menu if ouside clicked * [refactor] refetch card data once card is created, deleted, updated (#124) * β»οΈ refactor: trigger store add card * β»οΈ refactor: refetch card data once create,update,delete * β¨ feat: redirect to mydashboard if token is existed * [feat] add login and signup modal (#118) * π₯ remove: styled components β¨ feat: add authlayout component and implement responsive design β»οΈ refactor: rename layout file update login page structure and modify package-lock.json * β¨ feat: add signup page and css * π fix: type error * β»οΈ refactor: signup page css and move api folder * βοΈ feat: add login signup modal * π fix: install js-cookie * Revert "π fix: install js-cookie" This reverts commit bcc9109. * β»οΈ refactor: css structure and finalize styles * [fix] manage multiple cards in card store (#126) * π fix: manage multiple cards in card store * π fix: prevent duplicate cards and clear cards on dashboard navigation * π fix: push to index after logout (#128) * [style] improve dashboard uiux (#129) * π style: add min height to create column button * π style: improve UI/UX * π fix build error * π fix build error * π fix build error * π© style: update min-width for responsive design * π© style: update for responsive design * [fix] redirection for non token (#130) * π fix: redirection for non token * π fix: get total count on header members * βοΈ fix: typo * π remove: console * π fix: logout router replace * π fix: resolve delete column error (#132) --------- Co-authored-by: naji <[email protected]> Co-authored-by: κΉμ§μ€ <[email protected]> Co-authored-by: λμΉμ½ <[email protected]>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Related Issue
close #120
π Description