Skip to content

Conversation

@devmanta
Copy link
Collaborator

@devmanta devmanta commented Nov 17, 2024

πŸ“Œ Related Issue

close #17
close #20

πŸ“ Description

  • μ‚¬μ΄λ“œλ°” λŒ€μ‹œλ³΄λ“œ νŽ˜μ΄μ§€λ„€μ΄μ…˜ + css
  • 헀더 μš°μΈ‘μƒλ‹¨ 내정보 ν΄λ¦­μ‹œ 메뉴 λ“œλ‘­λ‹€μš΄ (μ• λ‹ˆλ©”μ΄μ…˜ 적용 아직x λ‚˜μ€‘μ—...)

πŸ“Έ Screenshot

image image image
image

πŸ“’ Notes

  • λͺ¨λ°”일뷰 νŽ˜μ΄λ„€μ΄μ…˜μ€ ν”Όκ·Έλ§ˆμ— μ—†μ–΄μ„œ κ·Έλƒ₯ μž„μ˜λ‘œ μΆ”κ°€
  • λ§ˆμ΄λ©”λ‰΄λ„ ν”Όκ·Έλ§ˆμ— μ—†μ–΄μ„œ μž„μ˜ μΆ”κ°€ (μš”κ΅¬μ‚¬ν•­μ—” μž‡μŒ)

@devmanta devmanta self-assigned this Nov 17, 2024
@devmanta devmanta requested review from a user, najitwo and naseungyeop November 17, 2024 11:53
);
}

function DashboardList({ dashboards }: { dashboards: Dashboard[] }) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런거 μ—¬κΈ°μ—μ„œλ§Œ 쓸꺼라 λ”°λ‘œ 파일둜 μ•ˆλΉΌκ³  κ·Έλƒ₯ ν•œκ°œνŒŒμΌ μ•ˆμ—μ„œ μ§„ν–‰ν–ˆλŠ”λ°
λ¨Όκ°€ κΈΈμ–΄λ³΄μ΄λŠ”κ±°κ°™κΈ°λ„ν•˜κ³ ... 걍 냅둬도 λ κ²ƒκ°™κΈ°λ„ν•˜κ³ ........κ·ΈλŸ¬λ„€μš”...γ…‹γ…‹γ…‹γ…‹γ…‹

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ €λŠ” 파일이 100 쀄 정도 λ„˜μ–΄κ°€λ©΄ 뢄리λ₯Ό μƒκ°ν•˜κΈ΄ ν•©λ‹ˆλ‹€.😊
근데 νŒŒμΌμ— Dashboards, DabshboadList κ°€ ν˜Όμš©λ˜μ„œ μ²˜μŒλ΄€μ„λ•Œ ν—·κ°ˆλ¦΄μˆ˜μžˆκ² λ„€μš”... πŸ˜‡

Copy link
Collaborator Author

@devmanta devmanta Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@najitwo κ·ΈλŸ¬λ„€μš”γ…œγ…‹γ…‹ s둜 μ“°κΈ°λ‘œν–‡λŠ”λ° λ¬΄μ§€μ„±μœΌλ‘œ 듀어가버렸넀..πŸ˜…
ν•¨μˆ˜ μ§€μ› μŠ΅λ‹ˆλ‹Ή

(λΉΌλ³΄λ €κ³ ν–ˆλŠ”λ°... cssλ­”κ°€κ°€ ν‹€μ–΄μ Έμ„œ... ν•¨μˆ˜λ§Œ μ§€μš°λŠ”κ±Έγ„Ή..)

Comment on lines +40 to +41
display: inherit;
width: inherit;
Copy link
Collaborator Author

@devmanta devmanta Nov 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거.. Linkμ‚¬μš© μ‹œ active μΆ”κ°€ν•  λ•Œ λ‚΄λ§˜λŒ€λ‘œ css ν΄λž˜μŠ€κ°€ μΆ”κ°€κ°€ μ•ˆλ˜λ”λΌκ΅¬μš”..
λ‚œλΆ„λͺ…νžˆ μΆ”κ°€λ₯Όν–ˆλŠ”λ° λ„₯μŠ€νŠΈκ°€ Link λ§ˆμš΄νŠΈν• λ•Œ 뭐 λ”°λ‘œ 처리λ₯Ό ν•˜λŠ”κ²ƒκ°™μ€λ° ν΄λž˜μŠ€κ°€ μ μš©μ΄μ•ˆλΌμš”γ… 

<Link
        href={`/dashboard/${id}`}
        className={`link ${isActive ? styles.active : styles.aaa}`}
      >

μ΄λŸ°μ‹μœΌλ‘œ μΆ”κ°€ν•˜λ©΄ aaa μ–˜λŠ” μ–΄λ–»κ²Œ 해도 μ μš©μ΄μ•ˆλ˜λ˜λ°... 뭐 λ”°λ‘œ legacybasis?인지먼지 속성 μΆ”κ°€ν•˜κ³  μžμ‹μš”μ†Œλ‘œ aνƒœκ·Έ λ„£κ³  해도 μ•ˆλκ³ .. css λͺ¨λ“ˆμ•ˆμ—μ„œλŠ” νƒœκ·Έμ„ νƒμžλŠ” μ•ˆλ˜κ°€μ§€κ³  그것도 μ μš©μ•ˆλŒ€κ³ ...
κ²°κ΅­.. reset으둜 μ™€μ„œ
aνƒœκ·ΈλŠ” displayλž‘ witdh λΆ€λͺ¨κΊΌ css μƒμ†λ°›κ²Œ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€

Copy link
Owner

@najitwo najitwo Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

className={link ${isActive ? styles.active : styles.aaa}}
μ—¬κΈ°μ„œ link μ• λŠ” λ­ν•˜λŠ” μ• μΈκ°€μš”???
<li></li> νƒœκ·Έλ‘œ κ°μ‹Έμ Έμžˆλ˜λ° 여기에 μŠ€νƒ€μΌμ„ μ μš©ν•˜λ©΄ λ˜μ§€μ•Šμ„κΉŒμš”???
그리고 μ•„λ§ˆ <li> νƒœκ·Έ μ—†μ• λ©΄ Link μŠ€νƒ€μΌ 잘 적용 될 것 κ°™μŠ΅λ‹ˆλ‹€.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@najitwo μ œκ°€ ν•˜κ³ μ‹Άμ—‡λ˜κ²Œ κ²°κ΅­ aνƒœκ·Έλ₯Ό display block처럼 전체 widthλ₯Ό λ¨ΉλŠ”κ±΄λ°
li에 μŠ€νƒ€μΌ μ μš©ν•΄λ„ κ·Έ μžμ‹μΈ aνƒœκ·ΈλŠ” inline μŠ€νƒ€μΌμ΄λΌ 전체 widthλ₯Ό μ•ˆλ¨Ήλ”λΌκ΅¬μš”πŸ« 

@devmanta devmanta added 🎨HTML&CSS Issues or tasks specifically related to HTML structure or CSS styling πŸ“¬API Tasks related to integrating or connecting to external APIs labels Nov 17, 2024
Copy link
Owner

@najitwo najitwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€ ~
νœ΄μΌμ—λ„ 열정이 λŒ€λ‹¨ν•˜μ‹œλ„€μš”πŸ”₯
저도 μ—΄μ‹¬νžˆν•˜κ² μŠ΅λ‹ˆλ‹€.. 😊

μ•„κΉŒ νŒ€λ―ΈνŒ…λ•Œ λ§μ”€λ“œλ¦° λŒ€μ‹œλ³΄λ“œ 제λͺ©?
헀더와 μ‚¬μ΄λ“œλ°”λ₯Ό κ°€μ§€κ³ μžˆλŠ” λ ˆμ΄μ•„μ›ƒμ—μ„œ 관리λ₯Ό ν•˜λ©΄ λ˜μ§€ μ•Šμ„κΉŒμš”?? 라고
μ‘°μ‹¬μŠ€λŸ½κ²Œ 의견 λ‚΄λ΄…λ‹ˆλ‹€. μ•„λ‹ˆλ©΄ 내일 λ©˜ν† λ§μ‹œκ°„μ— μ§ˆλ¬Έλ“œλ¦¬λŠ”κ±Έλ‘œ...πŸ€”

그리고 λ§ˆμ΄νŽ˜μ΄μ§€μ—μ„œ λ’€λ‘œκ°€κΈ°ν–ˆμ„λ•Œ λ§ˆμ΄νŽ˜μ΄μ§€ module.cssκ°€ μ™ μ§€ λͺ¨λ₯΄κ²Œ λ‚¨μ•„μžˆλ„€μš”... 이것도 μ§ˆλ¬Έλ“œλ €μ•Όλ κ±°κ°™μ•„μš”

@devmanta devmanta merged commit 0a2a5a7 into develop Nov 18, 2024
1 check passed
@devmanta devmanta deleted the 17-sidebar-dashboards branch November 18, 2024 02:38
najitwo pushed a commit that referenced this pull request Nov 18, 2024
* πŸ’„ style: sidebar dashboard active style

* πŸ’„ style: add sidebar dashboard style

* πŸ’„ style: add sidebar dashboard gap and title style

* πŸ’„ style: modify sidebar border

* 🩹 style: roll back for sidebar border

* ✨ feat: add sidebar dashboard pagination

* πŸ’„ style: add sidebar pagniation arrow css

* ✨ feat: add navigation on logo

* ✨ feat: add header myInfo menu

* ♻️ refactor: extract user type

* ♻️ refactor: remove DashboardList function
najitwo pushed a commit that referenced this pull request Nov 23, 2024
* πŸ’„ style: sidebar dashboard active style

* πŸ’„ style: add sidebar dashboard style

* πŸ’„ style: add sidebar dashboard gap and title style

* πŸ’„ style: modify sidebar border

* 🩹 style: roll back for sidebar border

* ✨ feat: add sidebar dashboard pagination

* πŸ’„ style: add sidebar pagniation arrow css

* ✨ feat: add navigation on logo

* ✨ feat: add header myInfo menu

* ♻️ refactor: extract user type

* ♻️ refactor: remove DashboardList function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

πŸ“¬API Tasks related to integrating or connecting to external APIs 🎨HTML&CSS Issues or tasks specifically related to HTML structure or CSS styling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] add header myInfo dropdown [feat] sidebar dashboards

3 participants