[feat] add header and sidebar layout #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
devmanta
added
✨Feature
devmanta
changed the title
najitwo
reviewed
Nov 15, 2024
Owner
najitwo
left a comment
najitwo
left a comment
There was a problem hiding this comment.
첫 PR 축하드립니다. 🎉
레이아웃관련이라 크게 리뷰할것이 없어보이네요
header는 유저정보를 가지고 있어야 되고
sidebar는 유저 인터렉션이 있어야 하니
'use client'는 맞게 잘 적용하신 것 같습니다!
.eslintrc.ci.json
Outdated
Owner
There was a problem hiding this comment.
이렇게 파일을 새로 생성하기 보다는
"@typescript-eslint/no-unused-vars": "warn"
에러를 경고수준으로 낮추기만 하면 다 해결될것 같은데 어떻게 생각하세요?
Collaborator
Author
There was a problem hiding this comment.
@najitwo 요거는 로컬에서할때는 빨갛게 뜨게 하고싶어서 warn으로 안하긴했거든요
warn으로 할까요..?ㅋㅋㅋ
| @@ -0,0 +1,3 @@ | |||
| .header { | |||
| color: yellowgreen; | |||
Owner
There was a problem hiding this comment.
variables.css 에 정의되지 않은 색상을 사용하셨는데
임시로 설정하신건가요?
Collaborator
Author
There was a problem hiding this comment.
넵..! 적용 잘되는지 확인용 임시입니다!
najitwo
approved these changes
Nov 15, 2024
najitwo
pushed a commit
that referenced
this pull request
Nov 18, 2024
* ✨ feat: add header and sidebar layout * 👷 chore: add no-unused-vars off on ci lint * 🚀 chore: make no-unused-vars as warn
najitwo
pushed a commit
that referenced
this pull request
Nov 23, 2024
* ✨ feat: add header and sidebar layout * 👷 chore: add no-unused-vars off on ci lint * 🚀 chore: make no-unused-vars as warn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Related Issue
📝 Description
📢 Notes