Skip to content

Conversation

@devmanta
Copy link
Collaborator

πŸ“Œ Related Issue

close #19

πŸ“ Description

  • λ‚΄ λŒ€μ‹œλ³΄λ“œμ— λŒ€μ‹œλ³΄λ“œ μΉ΄λ“œ 리슀트 μ˜μ—­ κ΅¬ν˜„
  • μ΄ˆλŒ€ν•˜κΈ° μ—†μ„λ•Œ μ˜μ—­ κ΅¬ν˜„
  • button κ³΅ν†΅μ»΄ν¬λ„ŒνŠΈ μ‚¬μš©μ„ μœ„ν•΄ λͺ…μ‹œλ„ 높이기

πŸ“Έ Screenshot

image image

πŸ“’ Notes

  • λ¨Όκ°€.. page μ˜μ—­ μͺ½μ΄ 높이가 λ‚΄λ§˜λŒ€λ‘œ 컨트둀이 μ•ˆλ˜λ„€μš” γ…‹γ…‹γ…‹... mainνƒœκ·Έ μ•ˆμ— μžˆλŠ” μΉœκ΅¬λ“€ 높이가 κΈΈμ–΄μ§€λ©΄ μ‚¬μ΄λ“œλ°” 라인이 λ‹€ μ•ˆκ·Έλ €μ§€λŠ”κ±°κ°™μ•„μ„œ μ΄κ±°λŠ” μ΄ˆλŒ€ν•˜κΈ° λ¬΄ν•œμŠ€ν¬λ‘€λ•Œ 맞λ‹₯λ“œλ¦΄κ²ƒκ°™μ•„ λ‹€μŒ μž‘μ—…λ•Œ μ§„ν–‰ν•΄λ³΄κ² μŠ΅λ‹€
  • λ²„νŠΌ ν˜Έλ²„ λ§˜λŒ€λ‘œ μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€ γ…Žγ…Žγ…Žγ…Ž

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ–œ λ‘œμ»¬μ—μ„œ ν•΄λ³΄λ €κ³ ν•œκ±΄λ° λ”Έλ €κ°”λ„€μš”.. λ‹΄λ²ˆμ— μ§€μš°λ„λ‘ν•˜κ² μŠ΅λ‹ˆλ‹€ (μ•„λ‹˜ μ μš©ν•˜λ˜μ§€..?)

@devmanta devmanta self-assigned this Nov 18, 2024
@devmanta devmanta requested review from a user, najitwo and naseungyeop November 18, 2024 07:14
@devmanta devmanta added the ✨Feature Request for a new feature or functionality label Nov 18, 2024
Copy link
Owner

@najitwo najitwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μž‘μ—…μ΄ 되게 λΉ λ₯΄μ‹œλ„€μš”..πŸ‘
λ³„λ‘œ μ½”λ©˜νŠΈ λ“œλ¦΄ 것은 μ—†κ³  κ·Έλƒ₯ μž‘κ²Œλ‚˜λ§ˆ κ°œμ„ μ  μ œμ•ˆλ“œλ ΈμŠ΅λ‹ˆλ‹€.


export default function useDashboards({ pageSize }: UseDashboardsParams) {
const [page, setPage] = useState(1);
const { data } = useApi<GetDashboardsResponse>('/dashboards', {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ‚˜μ€‘μ— isLoading 도 같이 λ°›μ•„μ˜€λ©΄ 쒋을 κ±° κ°™μŠ΅λ‹ˆλ‹€~

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν…ŒμžŒλ…ΈνŠΈπŸ«‘

}: {
currentPage: number;
totalPages: number;
onPageChange: (direction: 'next' | 'prev') => void;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

νƒ€μž…μ„ λΆ„λ¦¬ν•΄μ£Όμ‹œλ©΄ 가독성에 더 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ € next | prev만 λ”°λ‘œμš”..?

Suggested change
onPageChange: (direction: 'next' | 'prev') => void;
type PageChangeDirection = 'next' | 'prev';
onPageChange: (direction: PageChangeDirection) => void;

μš”λŸ°λŠλ‚Œ λ§μ”€ν•˜μ‹œλŠ”κ±° λ§žμ„κΉŒμš”?
μ—¬κΈ°μ„œλ°–μ— μ•ˆμ¨κ°€μ§€κ΅¬ λ°”λ‘œ 보기 νŽΈν•œλŠλ‚Œμ΄ μ—†μ§€μ•Šμ•„ μžˆμŠ΅λ‹ˆλ‹€...γ…Žγ…Žγ…Žγ…Ž

src={
isFirstPage
? '/icons/arrow_left_light.svg'
: '/icons/arrow_left.svg'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ³„λ„λ‘œ λ³€μˆ˜λ‘œ λΆ„λ¦¬ν•˜λ©΄ μ–΄λ–¨κΉŒμš”??

const leftArrowSrc = isFirstPage
  ? '/icons/arrow_left_light.svg'
  : '/icons/arrow_left.svg';

const rightArrowSrc = isLastPage
  ? '/icons/arrow_right_light.svg'
  : '/icons/arrow_right.svg';

<DashboardCard key={board.id} {...board} />
))}
</section>
{dashboards.length > 0 && (
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{dashboards.length > 0 && (
{totalPages > 0 && (

여기에 totalPages λ³€μˆ˜λ₯Ό μ΄μš©ν•΄λ„ 될 것 κ°™μŠ΅λ‹ˆλ‹€.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λͺ¬κ°€.. λŒ€μ‹œλ³΄λ“œκ°€ 있으면~~ 이런 사고 νλ¦„μœΌλ‘œ dashboards.length κ°€ μ’€ 더 직관적이지 μ•Šμ„κΉŒ? μ‹ΆμŠ΅λ‹ˆλ‹€!

@devmanta devmanta merged commit 05599f4 into develop Nov 18, 2024
najitwo pushed a commit that referenced this pull request Nov 18, 2024
* ✨ feat: add mydashboard page dashboard cards

* ✨ feat: add mydashboard add dashboard button

* πŸ’„ style: mydashboard pagination css

* πŸ’„ style: add non-visibility of pagination if dashboards does not exist

* ✨ feat: add empty invitations

* ♻️ refactor: add button class specificity

* πŸ’„ style: sidebar dashboard add padding and remove gap

* 🎨 refactor: extract arrow src to const
@devmanta devmanta deleted the 19-mydashboard-main branch November 20, 2024 09:12
najitwo pushed a commit that referenced this pull request Nov 23, 2024
* ✨ feat: add mydashboard page dashboard cards

* ✨ feat: add mydashboard add dashboard button

* πŸ’„ style: mydashboard pagination css

* πŸ’„ style: add non-visibility of pagination if dashboards does not exist

* ✨ feat: add empty invitations

* ♻️ refactor: add button class specificity

* πŸ’„ style: sidebar dashboard add padding and remove gap

* 🎨 refactor: extract arrow src to const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨Feature Request for a new feature or functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] add mydashboard main page

3 participants