[feat] add login check and responsive design #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 18, 2024 00:08
* β¨ feat: add header, main and footer sections * β¨ feat: add logo to header * β¨ feat: add links to header * π fix: resolve import error of SVG components * β¨ feat: remove till attribute for dynamic styling of icon SVG * π§ chore: add PNG fallback for unoptimized SVG in Image component * β¨ feat: add images for landing page * β¨ feat: add header and footer layout * β¨ feat: add part of the main section * π fix: change any type to specific type in svg module * β»οΈ refactor: add responsive image component * π§ chore: add montserrat font to main section * β¨ feat: add custom logo svg component * β»οΈ refactor: add card component * π§ chore: add images for landing page * β¨ feat: add card components * β¨ feat: add UI elements for landing page
β¦://github.com/najitwo/10-Sprint-Taskify into 21-feat-add-login-check-and-responsive-design
ghost
added
π¨Refactor
ghost
self-assigned this
3 tasks
najitwo
approved these changes
Nov 18, 2024
Owner
najitwo
left a comment
najitwo
left a comment
There was a problem hiding this comment.
κ³ μνμ
¨μ΅λλ€.πππ
λλ©νμ΄μ§λΌμ μ½λ©νΈ λλ¦΄κ² μλ€μ π
|
|
||
| body { | ||
| font-family: var(--font-pretendard), sans-serif; | ||
| height: 100vh; |
Owner
There was a problem hiding this comment.
μ΄κ±° @devmanta λμ΄ μΆκ°νμ κ±° κ°μλ°
μ§μ°μ μ΄μ κ° λκ°μ??
Collaborator
There was a problem hiding this comment.
μΌμ γ μ΄κ±° μμ΄μ§λ©΄ μλλλ°γ γ
| @@ -1,129 +1,16 @@ | |||
| 'use client'; | |||
Owner
There was a problem hiding this comment.
λλ©νμ΄μ§λΌμ λΈλΌμ°μ μΈν°λ μ
μ΄ μμ κ² κ°μλ°
'use client';λ μ μλ건κ°μ???
Author
There was a problem hiding this comment.
μΆν μΆκ°λ κ² κ°μμ λ£μ΄λλλ° μ°μ μ λΆνμνλκΉ μ κ±°νκ² μ΅λλ€ π«‘
devmanta
approved these changes
Nov 18, 2024
| } | ||
|
|
||
| .logo { | ||
| fill: white; |
Collaborator
There was a problem hiding this comment.
λκ°κ²μ§λ§ μ ν¬ variablesμ whiteμμ΄μ κ·Έκ±° κ°λ€ μ¨λ μ’κ² λ€μ~
Author
There was a problem hiding this comment.
varλ buttonλ λ§μΆ°μ κ³ μΉκ² μ΅λλ€ γ γ γ
β¦into 21-feat-add-login-check-and-responsive-design
|
The latest updates on your projects. Learn more about Vercel for Git βοΈ 1 Skipped Deployment
|
ghost
merged commit
najitwo
pushed a commit
that referenced
this pull request
Nov 23, 2024
* β»οΈ refactor: improve layout and components structure * β¨ [feat] add layout for landing page (#12) * β¨ feat: add header, main and footer sections * β¨ feat: add logo to header * β¨ feat: add links to header * π fix: resolve import error of SVG components * β¨ feat: remove till attribute for dynamic styling of icon SVG * π§ chore: add PNG fallback for unoptimized SVG in Image component * β¨ feat: add images for landing page * β¨ feat: add header and footer layout * β¨ feat: add part of the main section * π fix: change any type to specific type in svg module * β»οΈ refactor: add responsive image component * π§ chore: add montserrat font to main section * β¨ feat: add custom logo svg component * β»οΈ refactor: add card component * π§ chore: add images for landing page * β¨ feat: add card components * β¨ feat: add UI elements for landing page * β»οΈ refactor: improve layout and components structure
najitwo
pushed a commit
that referenced
this pull request
Nov 23, 2024
* β»οΈ refactor: improve layout and components structure * β¨ [feat] add layout for landing page (#12) * β¨ feat: add header, main and footer sections * β¨ feat: add logo to header * β¨ feat: add links to header * π fix: resolve import error of SVG components * β¨ feat: remove till attribute for dynamic styling of icon SVG * π§ chore: add PNG fallback for unoptimized SVG in Image component * β¨ feat: add images for landing page * β¨ feat: add header and footer layout * β¨ feat: add part of the main section * π fix: change any type to specific type in svg module * β»οΈ refactor: add responsive image component * π§ chore: add montserrat font to main section * β¨ feat: add custom logo svg component * β»οΈ refactor: add card component * π§ chore: add images for landing page * β¨ feat: add card components * β¨ feat: add UI elements for landing page * β»οΈ refactor: improve layout and components structure
najitwo
pushed a commit
that referenced
this pull request
Nov 23, 2024
* β»οΈ refactor: improve layout and components structure * β¨ [feat] add layout for landing page (#12) * β¨ feat: add header, main and footer sections * β¨ feat: add logo to header * β¨ feat: add links to header * π fix: resolve import error of SVG components * β¨ feat: remove till attribute for dynamic styling of icon SVG * π§ chore: add PNG fallback for unoptimized SVG in Image component * β¨ feat: add images for landing page * β¨ feat: add header and footer layout * β¨ feat: add part of the main section * π fix: change any type to specific type in svg module * β»οΈ refactor: add responsive image component * π§ chore: add montserrat font to main section * β¨ feat: add custom logo svg component * β»οΈ refactor: add card component * π§ chore: add images for landing page * β¨ feat: add card components * β¨ feat: add UI elements for landing page * β»οΈ refactor: improve layout and components structure
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Related Issue
π Description
π’ Notes
-- λΈλμΉ μλ‘ νμ λλ¨Έμ§ μ²΄ν¬λ¦¬μ€νΈ μΆν μμ νκ² μ΅λλ€