Skip to content

[feat] add forms to mypage #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
najitwo merged 1 commit into from
Nov 16, 2024
Merged

[feat] add forms to mypage #6

najitwo merged 1 commit into from
Nov 16, 2024

Conversation

@najitwo
Copy link
Owner

@najitwo najitwo commented Nov 15, 2024

๐Ÿ“Œ Related Issue

close #3

๐Ÿ“ Description

  • ๋งˆ์ดํŽ˜์ด์ง€ ํ”„๋กœํ•„, ๋น„๋ฐ€๋ฒˆํ˜ธ ๋ณ€๊ฒฝ ํผ ์ถ”๊ฐ€

@najitwo najitwo added the โœจFeature Request for a new feature or functionality label Nov 15, 2024
@najitwo najitwo requested review from a user, devmanta and naseungyeop November 15, 2024 14:43
@najitwo najitwo self-assigned this Nov 15, 2024
@najitwo najitwo linked an issue Nov 15, 2024 that may be closed by this pull request
[feat] add profile and password forms to mypage #3
Closed
2 tasks
devmanta
devmanta approved these changes Nov 15, 2024
View reviewed changes
Copy link
Collaborator

@devmanta devmanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿฅ‡ ์—„์ฒญ... ๋น ๋ฅด๊ฒŒ ๋งŽ์€ ๊ฒƒ์„ ํ•˜์…จ๋„ค์š”..
๊ณ ์ƒ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค..! ๋”ฑํžˆ ์ฝ”๋ฉ˜ํŠธ ํ• ๊ฑด ์—†๊ณ  ์งˆ๋ฌธ๋งŒ ์ข€ํ–ˆ๋„ค์š”..๐Ÿ˜…

src/app/mypage/components/ProfileForm.tsx
type="text"
name="email"
label="์ด๋ฉ”์ผ"
placeholder="[email protected]"
Copy link
Collaborator

@devmanta devmanta Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ฉ”์ผ ๊ฐ’์—๋Š” ๋ฆฌ๋“œ์˜จ๋ฆฌ๋กœ ํ•ญ์ƒ ๊ฐ’์ด ์žˆ์„๊ฒƒ ๊ฐ™์€๋ฐ ์š”๊ฑฐ ์›น์ ‘๊ทผ์„ฑ๊ฐ™์€๊ฑฐ์— ํ•„์š”ํ•œ ๋ถ€๋ถ„์ธ๊ฐ€์š”..?!

Copy link
Owner Author

@najitwo najitwo Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์š”๊ตฌ์‚ฌํ•ญ์— ์ด๋ฉ”์ผ์€ ์ˆ˜์ • ๋ถˆ๊ฐ€๋Šฅ์ด๋ผ readonly๋กœ ๋„ฃ์—ˆ์Šต๋‹ˆ๋‹ค!

Copy link
Collaborator

@devmanta devmanta Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„ ๋ฆฌ๋“œ์˜จ๋ฆฌ๋ง๊ณ  placeholder๋งํ•œ๊ฑฐ์—์š”!ใ…‹ใ…‹ ์Ÿค๋Š” ์—ฌ๊ธฐ์„œ ์–ด์ฐจํ”ผ ์•ˆ๋ณด์ผ๊ฒƒ๊ฐ™์€๋ฐ ์›น์ ‘๊ทผ์„ฑ๋•Œ๋งค ๋„ฃ์–ด์•ผํ•œ๊ฑด๊ฐ€์‹ถ์–ด์„œ์š” ใ…‹ใ…‹

Copy link
Owner Author

@najitwo najitwo Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํ”ผ๊ทธ๋งˆ์ƒ์— ์Šคํƒ€์ผ์ด placeholder๋ž‘ ๊ฐ™์•„์„œ ๋„ฃ์–ด๋’€์Šต๋‹ˆ๋‹ค. ใ…‹ใ…‹ใ…‹
๋‚˜์ค‘์— post ์š”์ฒญ๋ณด๋‚ด๋ ค๋ฉด ์ง์ ‘์ ์œผ๋กœ ๊ฐ’์ด ์žˆ์–ด์•ผ ํ•˜๋‹ˆ ์ˆ˜์ •์ด ํ•„์š”ํ•˜๊ฒ ๋„ค์š”

src/app/mypage/components/FileInput.tsx
type="file"
accept="image/png, image/jpeg"
name={name}
id={name}
Copy link
Collaborator

@devmanta devmanta Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name๊ฐ’์€ ํ•ญ์ƒ imgFile ๊ฐ’์ธ๊ฐ€์š”..? FileInputProps ์ธํ„ฐํŽ˜์ด์Šค์— name: 'imgFile'; ์ด๋ ‡๊ฒŒ ๋˜์–ด์žˆ๊ธธ๋ž˜..
ํ•œ๊ณณ์—์„œ ํ•œ๋ฒˆ๋งŒ ์“ฐ๋Š” ์šฉ๋„๋ผ๋ฉด ๊ดœ์ฐฎ์„๊ฒƒ๊ฐ™์€๋ฐ ๊ณตํ†ต์ปดํฌ๋„ŒํŠธ๋กœ ์ƒ๊ฐํ•˜๋ฉด id๊ฐ€ ์ค‘๋ณต๋ ์ˆ˜ ์žˆ๋Š” ์ƒํ™ฉ์ด์žˆ์„๊ฒƒ๊ฐ™์Šต๋‹ˆ๋‹ค!

Copy link
Owner Author

@najitwo najitwo Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์žฌ์‚ฌ์šฉ์„ฑ์„ ๊ณ ๋ คํ•ด์„œ ์ˆ˜์ •ํ•ด๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค.

src/app/mypage/components/ProfileForm.tsx
import FileInput from './FileInput';

export interface FormValues {
image: File;
Copy link
Collaborator

@devmanta devmanta Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์–˜๋Š” ์ด๋ฏธ์ง€๊ฐ€ ์˜ต์…”๋„๊ฐ’์ด ์•„๋‹Œ๋ฐ ๋งŒ์•ฝ์— ์ด๋ฏธ์ง€ ์—†์œผ๋ฉด ์–ด๋–ป๊ฒŒ ๋˜๋Š”๊ฑฐ์—์š”..?

Copy link
Owner Author

@najitwo najitwo Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ํƒ€์ž…์—๋Ÿฌ๊ฐ€ ๋ฐœ์ƒํ• ๊ฒƒ ๊ฐ™๋„ค์š”.
API ์—ฐ๋™ํ•˜๋ฉด์„œ
image?: File; ๋‚˜ image: File | null;๋กœ ๋ฐ”๊ฟ” ๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค.

@najitwo najitwo merged commit 7609abf into develop Nov 16, 2024
1 check passed
@najitwo najitwo deleted the 3-feat-add-profile-and-password-forms-to-mypage branch November 17, 2024 05:20
najitwo added a commit that referenced this pull request Nov 18, 2024
@najitwo
[feat] add forms to mypage (#6)
1329b84
najitwo added a commit that referenced this pull request Nov 23, 2024
@najitwo
[feat] add forms to mypage (#6)
14b1c9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devmanta devmanta devmanta approved these changes

@naseungyeop naseungyeop Awaiting requested review from naseungyeop

Assignees

@najitwo najitwo

Labels

โœจFeature Request for a new feature or functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feat] add profile and password forms to mypage

3 participants

@najitwo @devmanta