Skip to content

[feat] add auth layout #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
devmanta merged 12 commits into from
Nov 26, 2024
Merged

[feat] add auth layout #61

devmanta merged 12 commits into from
Nov 26, 2024

Conversation

@naseungyeop
Copy link
Collaborator

@naseungyeop naseungyeop commented Nov 23, 2024 •
edited
Loading

πŸ“Œ Related Issue

close #58

πŸ“ Description

  • 둜그인/νšŒμ›κ°€μž…μ—μ„œ μ‚¬μš©ν•  곡톡 λ ˆμ΄μ•„μ›ƒ μ»΄ν¬λ„ŒνŠΈλ₯Ό μ œμž‘ν•˜μ—ΏμŠ΅λ‹ˆλ‹€

πŸ“Έ Screenshot

πŸ“’ Notes

@najitwo
Copy link
Owner

najitwo commented Nov 23, 2024

κ³ μƒν•˜μ…¨μŠ΅λ‹ˆλ‹€. 😁

  1. λ ˆμ΄μ•„μ›ƒ 파일 μœ„μΉ˜, μ‚¬μš© 방법이 잘λͺ»λμŠ΅λ‹ˆλ‹€. λ‹€λ₯Έ 뢄듀이 μ–΄λ–»κ²Œ ν•˜μ…¨λŠ”μ§€ μ°Έκ³ ν•˜μ…”μ„œ μˆ˜μ •ν•΄μ£Όμ„Έμš”.
    (+ λ‘œκ³ λŠ” μ™œ λ ˆμ΄μ•„μ›ƒμ— λ“€μ–΄μžˆμ§€ μ•Šλ‚˜μš”?)

  2. 컀밋 νžˆμŠ€ν† λ¦¬ μ „ PR에 λ§μ”€λ“œλ¦° 것 같은데 또 κΈ°μ°¨ 놀이 ν•˜κ³  μžˆλ„€μš”~ πŸš‚
    브랜치 μƒˆλ‘œ 생성 ν•  λ•Œ μ–΄λ–»κ²Œ μ§„ν–‰ν•˜μ‹œλŠ”μ§€, μ–΄λŠ 뢀뢄이 이해 μ•ˆλ˜λŠ”μ§€ λ§μ”€λΆ€νƒλ“œλ¦½λ‹ˆλ‹€~

devmanta
devmanta reviewed Nov 24, 2024
View reviewed changes
Copy link
Collaborator

@devmanta devmanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ§€μ›λ‹˜ λ§μ”€μ²˜λŸΌ λ ˆμ΄μ•„μ›ƒ λΆ€λΆ„ κ΅¬μ‘°λž‘ λ‘œκ³ μΆ”κ°€ μˆ˜μ •ν•΄μ£Όμ‹œλ©΄ μ’‹μ„κ²ƒκ°™μŠ΅λ‹ˆλ‹€~!
ν•œμž… κ°•μ˜ 보셔도 되고, 저희 (with-header-sidebar) λΆ€λΆ„ 보셔도 λ κ²ƒκ°™μ•„μš”!

package-lock.json Outdated
"version": "3.1.3",
"resolved": "https://registry.npmjs.org/csstype/-/csstype-3.1.3.tgz",
"integrity": "sha512-M1uQkMl8rQK/szD0LNhtqxIPLpimGm8sOBwU7lLnCpSbTyY3yeU1Vc7l4KT5zT4s/yOxHH5O7tIuuLOCnLADRw==",
"devOptional": true,
Copy link
Collaborator

@devmanta devmanta Nov 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ–˜λŠ” μ™œμΆ”κ°€λœκ±°μ—μš”..!?

Copy link
Collaborator Author

@naseungyeop naseungyeop Nov 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

흠..그게 잘 λͺ¨λ₯΄κ²ŸμŠ΅λ‹ˆλ‹€ rebase ν•˜λ©΄μ„œ μˆ˜μ •ν•˜λ‹€λ³΄λ‹ˆ μ €κ²Œ μΆ”κ°€κ°€ λ«λ”λΌκ³ μš”

Copy link
Collaborator

@devmanta devmanta Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naseungyeop μš”κ±°ν•„μš”μ—†λŠ”κ±°λ©΄ λΉΌμ£Όμ„Έμš”!!

Copy link
Collaborator Author

@naseungyeop naseungyeop Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„΅ λΊμŠ΅λ‹ˆλ‹€

@devmanta devmanta added the 🎨HTML&CSS Issues or tasks specifically related to HTML structure or CSS styling label Nov 24, 2024
@naseungyeop naseungyeop added the πŸ”¨Refactor Code refactoring tasks to improve code structure and maintainability without changing functionality label Nov 26, 2024
devmanta
devmanta reviewed Nov 26, 2024
View reviewed changes
src/app/(user-access)/login/page.tsx Outdated
</Button>
<div style={{ display: 'flex', justifyContent: 'center' }}>
<p>
νšŒμ›μ΄ μ•„λ‹ˆμ‹ κ°€μš”?{' '}
Copy link
Collaborator

@devmanta devmanta Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

맨였λ₯Έμͺ½ λ„μ–΄μ“°κΈ°λŠ” μΌλΆ€λŸ¬ λ„£μœΌμ‹ κ±΄κ°€μš”?

Copy link
Collaborator Author

@naseungyeop naseungyeop Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„€..곡백이 μž‡λŠ”κ²Œ 더 μ΄λ»λ³΄μ—¬μ„œ

Copy link
Collaborator

@devmanta devmanta Nov 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naseungyeop μ•„.. μ € 사이사이 간격을 μ΄λ ‡κ²Œ ν•˜μ…¨κ΅°μš”..!
λ‹€μŒλ²ˆμ— css둜 μ²˜λ¦¬ν•˜λŠ” λ°©ν–₯ κ³ λ €ν•΄μ£Όμ‹œλ©΄ μ’‹μ„κ²ƒκ°™λ„€μš”~

Copy link
Collaborator Author

@naseungyeop naseungyeop Nov 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ„΅

devmanta
devmanta approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@devmanta devmanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ‚˜μ€‘μ— μž‘μ—…ν•˜μ‹€λ•ŒλŠ” page νŒŒμΌμ—λŠ” μ΅œμ†Œν•œμ˜ λ‚΄μš©λ§Œ 두고 μ»΄ν¬λ„ŒνŠΈν™” ν•˜λ©΄ μ’‹μ„κ²ƒκ°™μ•„μš”~

@devmanta
Copy link
Collaborator

devmanta commented Nov 26, 2024

PR λ””μŠ€ν¬λ¦½μ…˜μ— close #58 μ΄λŸ°μ‹μœΌλ‘œ 쓰셔야지 ν•΄λ‹Ή 이슈 μžλ™ ν΄λ‘œμ¦ˆλ©λ‹ˆλ‹€

@devmanta devmanta merged commit 7a39b3a into develop Nov 26, 2024
1 check passed
@naseungyeop naseungyeop deleted the 58-add-auth-layout branch November 28, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devmanta devmanta devmanta approved these changes

Assignees

@naseungyeop naseungyeop

Labels

🎨HTML&CSS Issues or tasks specifically related to HTML structure or CSS styling πŸ”¨Refactor Code refactoring tasks to improve code structure and maintainability without changing functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[feat] add authlayout component

4 participants

@naseungyeop @najitwo @devmanta