Skip to content

Conversation

@najitwo
Copy link
Owner

@najitwo najitwo commented Nov 25, 2024

๐Ÿ“Œ Related Issue

close #66

๐Ÿ“ Description

  • ๋ชจ๋‹ฌ์— focusTrap ๋ถ™์ด๊ธฐ (ํฌ์ง„๋‹˜๊บผ ํ›”์นจ)
    -> ํฌ์ง„๋‹˜๊บผ ๊ฐ€์ ธ๋‹ค ์“ฐ๋ ค๊ณ ํ•˜๋‹ˆ๊น ์ฒซ๋ฒˆ์งธ ์š”์†Œ ๊ฐ•์ œ์ ์œผ๋กœ ํฌ์ปค์‹ฑํ•˜๊ธธ๋ž˜ ๊ทธ ๋ถ€๋ถ„ ์ˆ˜์ •ํ•˜๊ณ  ๋งŒ๋“ค์—ˆ์Šต๋‹ˆ๋‹ค. (๋“œ๋กญ๋‹ค์šด์ด ๊ฐ•์ œ์ ์œผ๋กœ ํŽด์ง ๐Ÿ˜“)
  • ๋ชจ๋‹ฌ fadein, fadeout ์• ๋‹ˆ๋ฉ”์ด์…˜ ์ถ”๊ฐ€
  • ๋’ค๋กœ๊ฐ€๊ธฐ, ์•ž์œผ๋กœ๊ฐ€๊ธฐ ์ด๋™ ๊ฐ์ง€ํ•ด์„œ ๋ชจ๋‹ฌ ์—†์• ๊ธฐ
  • ๋ชจ๋‹ฌ ์œ„์น˜ src/app/(with-header-sidebar) ๊นŒ์ง€ ์˜ฌ๋ ธ์Šต๋‹ˆ๋‹ค. ์‚ฌ์šฉํ•˜์‹ค ๋ถ„ ์‚ฌ์šฉํ•˜์…”๋„๋ฉ๋‹ˆ๋‹ค.
  • ๋‹ด๋‹น์ž ๊ฒ€์ƒ‰ ๋“œ๋กญ๋‹ค์šด ๊ตฌํ˜„
  • datepicker ๊ธฐ๋Šฅ๋งŒ ๊ตฌํ˜„
  • Avatar ์ปดํฌ๋„ŒํŠธ ๋„ˆ๋ฌด ๋ฐ์€์ƒ‰์€ ์•ˆ๋‚˜์˜ค๊ฒŒ ์กฐ์ •

๐Ÿ“ธ Screenshot

image
image

๐Ÿ“ข Notes

์ฝ”๋“œ๊ฐ€ ๋งŽ์ด ๋”๋Ÿฝ์Šต๋‹ˆ๋‹ค.
โšฐ

@najitwo najitwo added โœจFeature Request for a new feature or functionality ๐Ÿ”จRefactor Code refactoring tasks to improve code structure and maintainability without changing functionality labels Nov 25, 2024
@najitwo najitwo requested review from a user, devmanta and naseungyeop November 25, 2024 20:19
@najitwo najitwo self-assigned this Nov 25, 2024
@najitwo najitwo linked an issue Nov 25, 2024 that may be closed by this pull request
2 tasks
Copy link
Collaborator

@devmanta devmanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ง„์งœ ์†๋„๊ฐ€ ์–ด๋งˆ์–ด๋งˆํ•˜์‹œ๋„ค์š”.. ๐Ÿซข
๋“œ๋กญ๋‹ค์šด์ด๋ž‘ ๋ฐ์ดํŠธํ”ผ์ปค์ชฝ ๋จผ๊ฐ€ ์˜๊ฒฌ์„ ๋“œ๋ฆฌ๊ณ  ์‹ถ์–ด์„œ ์—ฌ๋Ÿฌ๋ฒˆ ๋ดค๋Š”๋ฐ..
๋”ฐ๋กœ ๋ˆˆ์— ๋ณด์ด๊ฑฐ๋‚˜ ์ƒ๊ฐ๋‚˜๋Š” ๋จผ๊ฐ€๊ฐ€ ์—†๋„ค์š”..๐Ÿ˜… ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค..!!!

);
};

export default DatePicker;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์š”๊ฑฐ ์‹œ๊ฐ„๋„ ๊ฐ™์ด ์žˆ์œผ๋‹ˆ๊น DateTimePicker๊ฐ€ ๋” ์ข‹์•„๋ณด์—ฌ์š”!

tabIndex={0}
onClick={() => handleSelect(option)}
onMouseEnter={() => setFocusedIndex(index)}
role="option"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๊ฑฐ ์ถ”๊ฐ€ํ•˜๋ฉด ์–ด๋–ค๊ฒŒ ๋‹ฌ๋ผ์ง€๋Š”(?)๊ฑฐ์—์š”..!?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹ฌ๋ผ์ง€๋Š”๊ฑด ์•„๋‹ˆ๊ณ  ๊ทธ๋ƒฅ ์ ‘๊ทผ์„ฑ ๊ด€๋ จ ์ฝ”๋“œ๋กœ ์–˜๊ฐ€ option ํƒœ๊ทธ๋กœ ์ธ์‹๋˜์—ˆ์œผ๋ฉด ํ•œ๋‹ค! ๊ฐ™์€ ๊ฒ๋‹ˆ๋‹ค.

@najitwo najitwo merged commit ffa9e81 into develop Nov 26, 2024
1 check passed
naseungyeop pushed a commit that referenced this pull request Nov 27, 2024
* โœจ feat: add animation and FocusTrap to modal

* โœจ feat: implement search dropdown

* โœจ feat: implement datepicker
@najitwo najitwo deleted the 66-implement-dropdown-and-calendar branch November 27, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

โœจFeature Request for a new feature or functionality ๐Ÿ”จRefactor Code refactoring tasks to improve code structure and maintainability without changing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feat] implement dropdown and calendar

3 participants