Skip to content

[feat] add login functionality #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
naseungyeop merged 9 commits into from
Nov 18, 2024
Merged

[feat] add login functionality #9

naseungyeop merged 9 commits into from
Nov 18, 2024

Conversation

@naseungyeop
Copy link
Collaborator

@naseungyeop naseungyeop commented Nov 15, 2024 •
edited
Loading

๐Ÿ“Œ Related Issue

#8

๐Ÿ“ Description

  • ๋กœ๊ทธ์ธ ๊ธฐ๋Šฅ์„ ์ถ”๊ฐ€ํ•˜์—ฟ์Šต๋‹ˆ๋‹ค
  • zustand store๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค

๐Ÿ“ธ Screenshot

๐Ÿ“ข Notes

@naseungyeop
feat:add login functionality
dc12248
@naseungyeop
Merge branch '8-add-login-functionality' of https://github.com/najitwโ€ฆ
a64ec3a 
โ€ฆo/10-Sprint-Taskify into 8-add-login-functionality

header sidebarPS C:\Users\๋‚˜์Šน์—ฝ\Desktop\taskify\10-Sprint-Taskify> git
pull origin 8-add-login-functionality
remote: Enumerating objects: 21, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 16 (delta 4), reused 13 (delta 2), pack-reused 0 (from 0)
Merge branch '8-add-login-functionality' of
https://github.com/najitwo/10-Sprint-Taskify into
8-add-login-functionality
the commit.
~
~
~
~
~
~
~
~
~
~
.git/MERGE_MSG[+] [unix] (02:37 16/11/2024)
6,1 All
PS C:\Users\๋‚˜์Šน์—ฝ\Desktop\taskify\10-Sprint-Taskify> git pull origin
8-add-login-functionality
remote: Enumerating objects: 21, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 16 (delta 4), reused 13 (delta 2), pack-reused 0 (from 0)
Merge branch '8-add-login-functionality' of
https://github.com/najitwo/10-Sprint-Taskify into
8-add-login-functionality
the commit.
~
~
~
~
~
~
~
~
~
~
.git/MERGE_MSG[+] [unix] (02:37 16/11/2024)
6,1 All
PS C:\Users\๋‚˜์Šน์—ฝ\Desktop\taskify\10-Sprint-Taskify> git pull origin
8-add-login-functionality
remote: Enumerating objects: 21, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 16 (delta 4), reused 13 (delta 2), pack-reused 0 (from 0)
Merge branch '8-add-login-functionality' of
https://github.com/najitwo/10-Sprint-Taskify into
8-add-login-functionality
the commit.
~
~
~
~
~
~
~
~
~
~
.git/MERGE_MSG[+] [unix] (02:37 16/11/2024)
6,1 All
PS C:\Users\๋‚˜์Šน์—ฝ\Desktop\taskify\10-Sprint-Taskify> git pull origin
8-add-login-functionality
remote: Enumerating objects: 21, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 16 (delta 4), reused 13 (delta 2), pack-reused 0 (from 0)
Merge branch '8-add-login-functionality' of
https://github.com/najitwo/10-Sprint-Taskify into
8-add-login-functionality
the commit.
~
~
~
~
~
~
~
~
~
~
.git/MERGE_MSG[+] [unix] (02:37 16/11/2024)
6,1 All
PS C:\Users\๋‚˜์Šน์—ฝ\Desktop\taskify\10-Sprint-Taskify> git pull origin
8-add-login-functionality
remote: Enumerating objects: 21, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 16 (delta 4), reused 13 (delta 2), pack-reused 0 (from 0)
Merge branch '8-add-login-functionality' of
https://github.com/najitwo/10-Sprint-Taskify into
8-add-login-functionality
the commit.
~
~
~
~
~
~
~
~
~
~
.git/MERGE_MSG[+] [unix] (02:37 16/11/2024)
6,1 All
๏ฟฝ
PS C:\Users\๋‚˜์Šน์—ฝ\Desktop\taskify\10-Sprint-Taskify> git pull origin
8-add-login-functionality
remote: Enumerating objects: 21, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 16 (delta 4), reused 13 (delta 2), pack-reused 0 (from 0)
Merge branch '8-add-login-functionality' of
https://github.com/najitwo/10-Sprint-Taskify into
8-add-login-functionality
the commit.
~
~
~
~
~
~
~
~
~
~
.git/MERGE_MSG[+] [unix] (02:37 16/11/2024)
6,1 All
PS C:\Users\๋‚˜์Šน์—ฝ\Desktop\taskify\10-Sprint-Taskify> git pull origin
8-add-login-functionality
remote: Enumerating objects: 21, done.
remote: Counting objects: 100% (21/21), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 16 (delta 4), reused 13 (delta 2), pack-reused 0 (from 0)
Merge branch '8-add-login-functionality' of
https://github.com/najitwo/10-Sprint-Taskify into
8-add-login-functionality
the commit.
~
~
~
~
~
~
~
~
~
~
.git/MERGE_MSG[+] [unix] (02:37 16/11/2024)
6,1 All
@naseungyeop
refactor: Update login functionality
edec024
najitwo
najitwo reviewed Nov 15, 2024
View reviewed changes
Copy link
Owner

@najitwo najitwo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฒซ PR ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค. ๐Ÿ˜
์ปค๋ฐ‹ ๋ฉ”์„ธ์ง€๊ฐ€ ์ข€ ์ œ๊ฐ๊ฐ ์ธ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค?๐Ÿค”
๋ฌธ์„œ์— ๋ช…์‹œ๋œ ์ปค๋ฐ‹ ์ปจ๋ฒค์…˜์€ ์ง€์ผœ์ฃผ์…จ์œผ๋ฉด ์ข‹๊ฒ ์Šต๋‹ˆ๋‹ค.

src/api/auth/login.ts Outdated
const response = await axios.post(`${AUTH_URL}/login`, { email, password });
const { accessToken } = response.data;

localStorage.setItem('accessToken', accessToken);
Copy link
Owner

@najitwo najitwo Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋กœ์ปฌ์Šคํ† ๋ฆฌ์ง€๋ฅผ ์‚ฌ์šฉํ•˜์…จ๋Š”๋ฐ ์™œ ์‚ฌ์šฉํ•˜์…จ๋‚˜์š”?
๋กœ๊ทธ์ธ์š”์ฒญํ›„ ์‘๋‹ต ๋ฐ›์„๋•Œ accessToken์ด ์–ด๋””์— ์ €์žฅ๋˜๋Š”์ง€ ํ™•์ธํ•˜์…จ๋‚˜์š”?
์ €ํฌ ์ „์—ญ ์ƒํƒœ ๊ด€๋ฆฌ๋Š” zustand ์‚ฌ์šฉํ•˜๊ธฐ๋กœ ํ–ˆ์œผ๋‹ˆ zustand๋กœ ๊ด€๋ฆฌํ•˜๋Š” ๊ฒƒ์„ ์ถ”์ฒœ๋“œ๋ ค์š”.

Copy link
Collaborator Author

@naseungyeop naseungyeop Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zustand๋ฅผ ์‚ฌ์šฉํ•ด์„œ ๋‹ค์‹œ ์ˆ˜์ •ํ•˜๊ฒŸ์Šต๋‹ˆ๋‹ค

@naseungyeop naseungyeop self-assigned this Nov 16, 2024
@naseungyeop naseungyeop added the โœจFeature Request for a new feature or functionality label Nov 16, 2024
najitwo
najitwo approved these changes Nov 17, 2024
View reviewed changes
Copy link
Owner

@najitwo najitwo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋กœ๊ทธ์ธ ํŽ˜์ด์ง€๋Š” ์–ธ์ œ ๋งŒ๋“œ์‹ค ๊ณ„ํš์ด์‹ ๊ฐ€์š”??
๊ธฐ๋Šฅ ๋งŒ๋“ค๋•Œ ํŽ˜์ด์ง€๊นŒ์ง€ ๊ฐ™์ด ๋งŒ๋“ค์–ด ํ…Œ์ŠคํŠธ ํ–ˆ์œผ๋ฉด ์ข‹๊ฒ ์Šต๋‹ˆ๋‹ค. ๐Ÿ˜Š
์ด์Šˆ ํ…œํ”Œ๋ฆฟ์œผ๋กœ ์ž‘์„ฑํ•˜์‹ ๊ฑฐ ์™„๋ฃŒ๋˜์…จ์œผ๋ฉด ์ฒดํฌํ•ด์ฃผ์‹œ๊ณ 
๋ฆฌ๋ทฐ๊ฐ€ ํ•„์š”ํ•˜์‹œ๋ฉด ๋ฆฌ๋ทฐ ์žฌ์š”์ฒญํ•ด์ฃผ์„ธ์š”~

@naseungyeop naseungyeop merged commit 3968f34 into develop Nov 18, 2024
najitwo pushed a commit that referenced this pull request Nov 18, 2024
@naseungyeop @najitwo
[feat] add login functionality (#9)
4268b44 
* feat:add login functionality

* refactor: Update login functionality

* โœจ feat: add zustand store and fix login functionality

* ๐Ÿ› fix: linting issues

* ๐Ÿ› refactor: refactor update types in zustand store

* ๐Ÿ› refactor: update types in zustand store2

* โ™ป๏ธ refactor: authStore for token handling
najitwo pushed a commit that referenced this pull request Nov 23, 2024
@naseungyeop @najitwo
[feat] add login functionality (#9)
ac13165 
* feat:add login functionality

* refactor: Update login functionality

* โœจ feat: add zustand store and fix login functionality

* ๐Ÿ› fix: linting issues

* ๐Ÿ› refactor: refactor update types in zustand store

* ๐Ÿ› refactor: update types in zustand store2

* โ™ป๏ธ refactor: authStore for token handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@najitwo najitwo najitwo approved these changes

Assignees

@naseungyeop naseungyeop

Labels

โœจFeature Request for a new feature or functionality

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@naseungyeop @najitwo