Proper escaping for generated encrypted password hashes

[kristapsk]

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability of root password handling during image finalization to prevent issues with special characters in password hashes.

[coderabbitai]

Walkthrough

The script responsible for finalizing images now escapes dollar signs in the root password hash before inserting it into the shadow file. It also changes the sed substitution delimiter to avoid conflicts with slashes and updates the matching pattern for the root entry. These updates apply to both test and production image creation.

Changes

File	Change Summary
tools/finalize-nakamochi.sh	Escapes dollar signs in password hash before substitution, changes sed delimiter, updates pattern.

Poem

In the land of scripts, a change took root,
Escaping dollars—how astute!
With slashes tamed and hashes neat,
The shadow file is now complete.
Bashful bunny hops with pride,
Secure and tidy on the side!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

tools/finalize-nakamochi.sh (2)

274-275: Properly escape and substitute test-image root hash
Escaping \$ with sed 's/\$/\\\$/g' and switching the sed delimiter to | prevents misinterpretation of $ or / in the hashed password. This change ensures the fixed "nakamochi" password is safely injected into /etc/shadow.

You could eliminate the extra sed call by using Bash parameter expansion to escape $, for example:

crypted_root_pass="$(mkpasswd "$root_pass")"
# Escape all $ characters in-place
crypted_root_pass="${crypted_root_pass//\$/\\\$}"

---

282-283: Properly escape and substitute production-image root hash
The same escaping logic and | delimiter are applied to the random 13-character password, ensuring that slashes or dollar signs in the generated hash don’t break the sed substitution.

Similarly, capture the raw hash then escape via parameter expansion to avoid spawning sed twice:

raw_hash="$(mkpasswd "$(tr -dc 'A-Za-z0-9' </dev/urandom | head -c 13)")"
crypted_root_pass="${raw_hash//\$/\\\$}"

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 192cfb0 and adbe3ef.

📒 Files selected for processing (1)

• tools/finalize-nakamochi.sh (1 hunks)