Create ssh onion service for testing images #27
Conversation
WalkthroughThe script was updated to clarify its output message regarding onion service generation and to add functionality for creating an SSH onion service when finalizing test images. The new SSH onion service is generated, configured, and its hostname is displayed, but only when certain conditions are met during test image creation. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Script
participant mkp224o
participant SSD
participant Tor
User->>Script: Run finalize-nakamochi.sh
Script->>Script: Check if test_image and not skip_mkp224o
alt If test_image and not skip_mkp224o
Script->>mkp224o: Generate SSH onion service
mkp224o->>Script: Return onion service files
Script->>SSD: Copy onion service files to /tor/ssh
Script->>SSD: Set ownership to tor:tor
Script->>Tor: Append HiddenService config for SSH (if not present)
Script->>User: Output SSH onion service hostname
end
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tools/finalize-nakamochi.sh (1)
299-316: Verify SSH onion service configuration and cleanup temp files
- For consistency with other status messages, switch to
echo -n "Creating ssh onion service ... "so the trailing “done.” prints on the same line (line 300).- Confirm that the hard-coded
HiddenServiceDir /ssd/tor/sshpath matches the SSD mount point in the target image at runtime—if the device mounts SSD elsewhere, Tor won’t find the service directory.- Consider adding cleanup of
"$onion_tmp_dir"(e.g.,rm -rf "$onion_tmp_dir") or trapping it on exit to avoid orphaned temporary directories.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tools/finalize-nakamochi.sh(2 hunks)
🔇 Additional comments (1)
tools/finalize-nakamochi.sh (1)
229-234: Clarify onion service generation message
The updated echo now specifies "bitcoind and lnd onion services", which improves clarity over the previous generic message.
#26
Summary by CodeRabbit
New Features
Enhancements