Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions CI #17

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

kristapsk
Copy link
Member

Resolves #13.

@kristapsk kristapsk marked this pull request as draft July 18, 2024 14:43
@kristapsk
Copy link
Member Author

Still need to figure out how to make it work both from a branch and pull request. Main issue is fetching tags, otherwise semver check (7dc1f63) will fail. Couldn't make it work using GitHub checkout action.

@x1ddos
Copy link
Contributor

x1ddos commented Aug 8, 2024

looks like this fails before tags and anything else, at the checkout step:

image

isn't it supposed to use a github actions/checkout@v4 instead of a manual git clone ...? see https://github.com/actions/checkout

@kristapsk
Copy link
Member Author

kristapsk commented Aug 8, 2024

isn't it supposed to use a github actions/checkout@v4 instead of a manual git clone ...? see https://github.com/actions/checkout

See my comment above, couldn't get fetching tags using checkout action and that made semver check to fail.

But now I couldn't get it work both from a branch and in a PR. Will get back to this and try to fix, hopefully soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

set up a github CI
2 participants