Skip to content

Comments

Murisi/draft non breaking with test vectors 0.31.6#2728

Closed
murisi wants to merge 103 commits intomainfrom
murisi/draft-non-breaking-with-test-vectors-0.31.6
Closed

Murisi/draft non breaking with test vectors 0.31.6#2728
murisi wants to merge 103 commits intomainfrom
murisi/draft-non-breaking-with-test-vectors-0.31.6

Conversation

@murisi
Copy link
Collaborator

@murisi murisi commented Feb 26, 2024

Describe your changes

Testing merging #2727 into #2700 .

Indicate on which release or other PRs this topic is based on

#2727
#2700

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

murisi and others added 30 commits February 4, 2024 16:35
…(none) for empty values. Simplifies hardware wallets.
tzemanovic and others added 28 commits February 23, 2024 12:48
* tomas/refactor-state:
  changelog: add #2606
  benches: update for new state API
  test/wasm: update for new state API
  tests: update for new state API
  test/PoS: update for new state API
  apps: update for new state API
  namada: update for new state API, refactor tx and VP host envs
  sdk: update for new state API
  eth_bridge: update for new state API
  ibc: update for new state API
  state: refactor everything
* tomas/refactor-state:
  changelog: add #2606
  benches: update for new state API
  test/wasm: update for new state API
  tests: update for new state API
  test/PoS: update for new state API
  apps: update for new state API
  namada: update for new state API, refactor tx and VP host envs
  sdk: update for new state API
  eth_bridge: update for new state API
  ibc: update for new state API
  state: refactor everything
* fix-default-node:
  changelog: add #2701
  test/e2e: use the default `--node` in a test
  fix default node param protocol for cli calls
* murisi/mock-masp-prover:
  masp: move the mock stuff under testing sub-mod
  Added changelog entry.
  Do not allow MASP_TEST_SEED to be used outside of testing.
  Implemented a MockSaplingVerificationContext and enable it for testing flag.
  Modified the transaction generator to use mock prover when in testing mode.
* Krewedk0/main:
  fix ledger test
  fix formatting
  review fix, add changelog
  add slashed bonds/unbonds info to the client
* origin/tiago/rm-borsh-schemas:
  Changelog for #2682
  Stop building `namada_encoding_spec` in CI
  Remove borsh schema feat from Cargo manifest
  Remove borsh schema implementations
  Remove `namada_encoding_spec`
* origin/yuji/fix-ibc-shielded-transfer-back:
  add changelog
  fix token address when shielded transfer back to Namada
Namada 0.31.6 is a patch release that contains various fixes and improvements.
@codecov
Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 80.40449% with 436 lines in your changes are missing coverage. Please review.

Project coverage is 53.29%. Comparing base (0932a59) to head (b0a79ce).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/ibc/src/actions.rs 0.00% 107 Missing ⚠️
crates/core/src/event.rs 47.87% 49 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 47 Missing ⚠️
crates/governance/src/storage/proposal.rs 0.00% 39 Missing ⚠️
crates/apps/src/lib/node/ledger/shell/mod.rs 79.67% 25 Missing ⚠️
...rates/apps/src/lib/node/ledger/shell/governance.rs 53.84% 24 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs 0.00% 23 Missing ⚠️
...rc/protocol/transactions/ethereum_events/events.rs 88.94% 21 Missing ⚠️
crates/apps/src/lib/client/rpc.rs 0.00% 20 Missing ⚠️
crates/core/src/address.rs 75.47% 13 Missing ⚠️
... and 27 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2728      +/-   ##
==========================================
+ Coverage   52.99%   53.29%   +0.29%     
==========================================
  Files         303      307       +4     
  Lines      104166   103165    -1001     
==========================================
- Hits        55206    54984     -222     
+ Misses      48960    48181     -779     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murisi murisi closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants