Adding a shielding fee for normal shielding txs. #4726
Open
batconjurer wants to merge 25 commits intomainfrom
Open
Adding a shielding fee for normal shielding txs. #4726batconjurer wants to merge 25 commits intomainfrom
batconjurer wants to merge 25 commits intomainfrom
Conversation
tzemanovic
reviewed
Jul 14, 2025
Co-authored-by: Tomas Zemanovic <tomas@heliax.dev>
grarco
reviewed
Jul 14, 2025
grarco
reviewed
Jul 14, 2025
grarco
reviewed
Jul 14, 2025
grarco
reviewed
Jul 14, 2025
grarco
reviewed
Jul 15, 2025
grarco
reviewed
Jul 15, 2025
grarco
approved these changes
Jul 17, 2025
9f91824 to
41cda8f
Compare
Collaborator
|
Let's get some new reviews here |
3 tasks
3 tasks
Collaborator
|
Just want to note that the fee must only be taken if the associated tx is successful @sug0 |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4716
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo