info: Change elapsed time format in info #393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namhyung
reviewed
Jul 6, 2018
cmds/record.c
Outdated
| #define SEC_TO_NSEC (1000000000ULL) | ||
|
|
||
| char *elapsed_time = NULL; | ||
| static char *elapsed_fmt_time = NULL; |
There was a problem hiding this comment.
Right, it's not needed. Thanks.
honggyukim
force-pushed
the
check/elapsed-time-format
branch
from
b52c574 to
51c3876
Compare
|
I see. What about showing it as follows then? |
This patch changes elapsed time format more like replay output.
Before:
$ uftrace info
...
# elapsed time : 0.003219479 sec
# cpu time : 0.000 / 0.003 sec (sys / user)
...
After:
$ uftrace info
...
# elapsed time : 0.004970269 sec (4.970 ms)
# cpu time : 0.004 / 0.000 sec (sys / user)
...
Signed-off-by: Honggyu Kim <[email protected]>
honggyukim
force-pushed
the
check/elapsed-time-format
branch
from
51c3876 to
cfc84ef
Compare
namhyung
reviewed
Aug 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch changes elapsed time format more like replay output.
Before:
After:
Signed-off-by: Honggyu Kim [email protected]