Skip to content

Add Phone#14

Open
dan-kessler wants to merge 1 commit into
masterfrom
slipstream-po-phone
Open

Add Phone#14
dan-kessler wants to merge 1 commit into
masterfrom
slipstream-po-phone

Conversation

@dan-kessler

@dan-kessler dan-kessler commented Dec 7, 2021

Copy link
Copy Markdown

Added Phone to Party on PO

@dan-kessler

Copy link
Copy Markdown
Author

Added Phone to Party on PO

@jessejjohnson

Copy link
Copy Markdown
Member

⚠️ File history will not be retained

Given both the file names and content have been modified, these changes are seen as unrelated files deleted and added. The result will be two new files with no history or relation to the previous versions. This could be problematic as someone may need to reference previous versions but will be unable to view the original from the current.

To retain history, the simplest way would be to apply the file name changes and content changes within dedicated Pull Requests (once file name changes are approved and merged open another Pull Request with content changes).

@dan-kessler

Copy link
Copy Markdown
Author

That is a good point. I did not intend to delete the existing files in my PR. And this is problematic because there is no official 2021.1 release either. I will refactor this when I get a moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants