Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: substitutions processing #7

Merged
merged 5 commits into from
Jan 2, 2024
Merged

fix: substitutions processing #7

merged 5 commits into from
Jan 2, 2024

Conversation

brech1
Copy link
Collaborator

@brech1 brech1 commented Dec 22, 2023

Description

This PR introduces some changes to fix the way we were processing substitutions:

  • Removes declaration statement handling from execute_statement function, this shouldn't happen.
  • Updates the way we're assigning variables when executing a statement.
  • Adds some useful methods to the runtime module.
  • Fixes the way we're handling variable and signal declarations.

@brech1 brech1 marked this pull request as ready for review December 22, 2023 23:34
@brech1 brech1 merged commit 25ec383 into main Jan 2, 2024
1 check passed
@brech1 brech1 deleted the fix/substitutions branch January 11, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brech1