Rewrite natvis description for HashMap to improve the visualization of key-value pairs in WinDbg#6
Open
nanguye2496 wants to merge 1 commit intomasterfrom
Open
Conversation
nanguye2496
commented
Mar 1, 2021
| <!-- Bucket is populated --> | ||
| <Exec>n--</Exec> | ||
| <Item Name="{((tuple<$T1, $T2>*)base.table.ctrl.pointer)[-(i + 1)].__0}">((tuple<$T1, $T2>*)base.table.ctrl.pointer)[-(i + 1)].__1</Item> | ||
| <Item>((tuple<$T1,$T2>*)base.table.ctrl.pointer)[-(i + 1)]</Item> |
Owner
Author
There was a problem hiding this comment.
We should display each key-value pair as a tuple instead of having the key as the item name to allow developers to examine HashMap keys of user-defined types in WinDbg.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The natvis description of Rust HashMap contains this line:
WinDbg's natvis executor fails to cast
base.table.ctrl.pointertotuple<$T1, $T2>*, leading to this issue rust-lang#82674. The cause of this failure comes from WinDbg's syntax parser, which adds a whitespace between$T1and$T2after substituting them by the corresponding parametric types. While waiting for a fix from WinDbg side, I propose this work-around.For this program:
Here is the HashMap visualization before the fix:

Here is the HashMap visualization after the fix:
