fix(supply-chain): activate the minimumReleaseAge gate (hoist out of pnpm: key)#2973
Open
sturdy4days wants to merge 1 commit into
Open
fix(supply-chain): activate the minimumReleaseAge gate (hoist out of pnpm: key)#2973sturdy4days wants to merge 1 commit into
pnpm: key)#2973sturdy4days wants to merge 1 commit into
Conversation
…`pnpm:` key) pnpm reads a `pnpm:` config block only from package.json. In pnpm-workspace.yaml the setting must be top-level; nested under `pnpm:` it is silently ignored, so the declared 3-day supply-chain release-age gate has been a no-op since it was introduced. Verified with pnpm 10.33.0: nested (current) -> `pnpm config get minimumReleaseAge` = undefined top-level (fixed) -> `pnpm config get minimumReleaseAge` = 4320 No behavior change beyond making the already-declared gate effective. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
follows-guidelines
This was referenced Jul 8, 2026
Contributor
Author
|
@gavrielc @gabi-simons — when you have a chance, could one of you review this focused supply-chain configuration fix? The branch is mergeable and CI is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
What: Moves
minimumReleaseAge: 4320inpnpm-workspace.yamlfrom under apnpm:key to the top level.Why: pnpm reads a
pnpm:config block only frompackage.json. Inpnpm-workspace.yamlthe setting must be declared at the top level; nested under apnpm:key it is silently ignored, so the declared 3-day supply-chain release-age gate has been a no-op since it was added. New package versions were resolvable the moment they were published, with none of the intended soak time.How tested: with pnpm 10.33.0, on this repo's workspace:
No behavior change beyond making the already-declared gate effective.
Distinct from #2749, which gates agent-requested npm installs at runtime; this restores the build-time dependency-resolution gate that the workspace already intends to enforce.