fix(webhook): don't let a bind failure take down the whole host#2975
Open
wuisabel-gif wants to merge 1 commit into
Open
fix(webhook): don't let a bind failure take down the whole host#2975wuisabel-gif wants to merge 1 commit into
wuisabel-gif wants to merge 1 commit into
Conversation
The webhook server calls server.listen() with no 'error' handler, so if the port is already in use (a stray process, or a second nanoclaw copy) the EADDRINUSE surfaces as an uncaught exception and the entire host goes down — message polling, delivery and the sweep included, over one busy port. Handle 'error' instead: log the port and a hint, and keep the host up. The webhook-backed adapters stay dark until the conflict clears, but nothing else has to. Fixes nanocoai#2900
github-actions
Bot
added
the
follows-guidelines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webhook server calls server.listen() with no 'error' handler, so if the port is already in use (a stray process, or a second nanoclaw copy) the EADDRINUSE surfaces as an uncaught exception and the entire host goes down — message polling, delivery and the sweep included, over one busy port.
Handle 'error' instead: log the port and a hint, and keep the host up. The webhook-backed adapters stay dark until the conflict clears, but nothing else has to.
Fixes #2900
Type of Change
.claude/skills/<name>/, no source changes)Description
For Skills