Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Extend search params section #35

Merged
merged 3 commits into from
May 19, 2024
Merged

Docs: Extend search params section #35

merged 3 commits into from
May 19, 2024

Conversation

tordans
Copy link
Contributor

@tordans tordans commented May 19, 2024

Following the advice from #34 (comment) I was trying to clarify the search params section of the readme.

Changes include

… I still don't quite understand what the usecase for search:true is and how it would be used in an app.
I tried to use it in my app but failed to get something working that made sense.
This is my I mark this as a draft for now until this part is improved.
I also don't understand what "Parameters order will be critical." means. "Critical" in what way?

@ai ai marked this pull request as ready for review May 19, 2024 19:47
@ai
Copy link
Member

ai commented May 19, 2024

I still don't quite understand what the usecase for search:true is and how it would be used in an app.

It is rare case of /?page=a with the single param which define the page.

@ai ai merged commit 7320b94 into nanostores:main May 19, 2024
3 checks passed
@ai
Copy link
Member

ai commented May 19, 2024

Thanks for fixing the docs

@ai
Copy link
Member

ai commented May 19, 2024

Maybe we will remove it in next major release

@tordans tordans deleted the patch-1 branch May 19, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants