Bump the test runtime limit to 180 #291
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Not sure if this is still needed, but we were having a lot of issues with this last night and had a couple failures today. Going to let this sit for a bit and merge if it is still needed. |
Seems we are now going over the runtime limit for the Notebook executor. Not totally sure why, but it doesn't seem that we are going that far over as the tests do sometimes complete within the limit. It may be a dependency related change. Go ahead and bump the timeout another 60secs. Should afford the Notebook tests enough time to complete.
jakirkham
force-pushed
the
bump_test_runtime_limit
branch
from
094aa89 to
944b659
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems we are now going over the runtime limit for the Notebook executor. Not totally sure why, but it doesn't seem that we are going that far over as the tests do sometimes complete within the limit. It may be a dependency related change. Go ahead and bump the timeout another 60secs. Should afford the Notebook tests enough time to complete.