Skip to content

Commit

Permalink
Addresses review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
naotoj committed Jan 9, 2025
1 parent ac7f72f commit 47289b5
Showing 1 changed file with 5 additions and 8 deletions.
13 changes: 5 additions & 8 deletions test/jdk/tools/jlink/plugins/IncludeLocalesPluginTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
import org.junit.jupiter.params.provider.MethodSource;

import static org.junit.jupiter.api.Assertions.fail;
import static org.junit.jupiter.api.Assertions.assertNotNull;
import static org.junit.jupiter.api.Assertions.assertTrue;

/*
* @test
Expand Down Expand Up @@ -413,9 +415,7 @@ public static void setup() throws IOException {
"present.");

helper = Helper.newHelper(isLinkableRuntime);
if (helper == null) {
fail("Helper could not be initialized");
}
assertNotNull(helper, "Helper could not be initialized");
}

@ParameterizedTest
Expand Down Expand Up @@ -480,11 +480,8 @@ private static void testAvailableLocales(Path image, List<String> availableLocal
+ (len < availableLocales.size() ? " ..." : "");

int status = proc.waitFor();
if (status == 0) {
System.out.println("\tDone\t" + command);
} else {
fail("\tExit " + status + "\t" + command);
}
assertTrue(status == 0, "\tExit " + status + "\t" + command);
System.out.println("\tDone\t" + command);
System.out.println();
}
}

0 comments on commit 47289b5

Please sign in to comment.