Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #2003: Fix NXOS ping source_interface bugs #2004

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

decoupca
Copy link
Contributor

@decoupca decoupca commented Sep 6, 2023

Fixes two source_interface bugs in NXOS driver, whereby passing either an invalid or valid source_interface parameter returns an empty data structure.

@decoupca
Copy link
Contributor Author

decoupca commented Sep 6, 2023

This PR solves my original issue, but it's a good idea to include an else statement after the block starting on line 379 to catch any future similar errors. Should that raise an exception or just add the output to ping_dict["error"] like the first if statement?

@mirceaulinic mirceaulinic added this to the 5.0.0 milestone Mar 21, 2024
@mirceaulinic
Copy link
Member

@decoupca yes, I think it should explicitly raise an exception. Thanks!

@mirceaulinic mirceaulinic removed this from the 5.0.0 milestone Apr 10, 2024
@mirceaulinic
Copy link
Member

@decoupca is this still something you'd like to continue on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants