DO NOT Merge: Add commit confirmed plus commit message support #550

ktbyers · 2017-11-22T04:10:24Z

No description provided.

coveralls · 2017-11-22T04:12:11Z

Coverage decreased (-0.3%) to 77.84% when pulling 0b93f4f on commit_confirmed3 into cd37097 on develop.

ktbyers · 2017-11-22T04:14:22Z

Resubmitted due to some merge conflicts...see additional notes here: #544

mirceaulinic

@ktbyers is this ready (at least for IOS)? Junos and IOS-XR support both confirmed and message, I can continue from here if that's fine.

mirceaulinic · 2017-12-15T14:31:32Z

napalm/junos/junos.py

-    def commit_config(self):
+    def commit_config(self, confirmed=None, message=None):
        """Commit configuration."""
+        if confirmed is not None:


Junos supports commit confirmed (and message).

mirceaulinic · 2017-12-15T14:31:52Z

napalm/iosxr/iosxr.py


-    def commit_config(self):
+    def commit_config(self, confirmed=None, message=None):
+        if confirmed is not None:


IOS-XR too (also message).

coveralls · 2017-12-15T14:34:28Z

Coverage decreased (-0.3%) to 78.449% when pulling eb80297 on commit_confirmed3 into 29ee1e5 on develop.

ktbyers · 2017-12-20T17:57:23Z

@mirceaulinic Cisco IOS should be ready. I tested that when I implemented it.

ktbyers · 2017-12-20T18:00:19Z

@mirceaulinic Let me know when you add this into other platforms and I will regression test it in my lab environment.

We should also regression test it when it gets merged into develop branch (which I should be able to do also).

dbarrosop · 2018-01-02T08:00:35Z

napalm/base/base.py

        raise NotImplementedError

-    def commit_config(self):
+    def commit_config(self, confirmed=None, message=None):


We should document what "confirmed" is supposed to be.

I also really think we shouldn't name this variable confirmed. It is a terrible name; revert_in or timer are way better names.

confirmed is logical and is the most widely adopted name for this function. Basically saying you have to confirm this commit in how many minutes.

I think we will probably just add more confusion by naming it something else.

But agreed...it needs documented.

+1 on revert_in, describes the intent better. confirmed nomenclature maybe better known by network engineers, but I wouldn't cater to them exclusively with this library, you may have engineers without that background.

dbarrosop · 2018-01-02T08:04:01Z

I think this whole functionality requires two extra methods:

has_pending_commit() that returns whether if the system has a commit pending confirmation.
revert_commit() basically to shortcircuit the timer and revert immediately.

…onfirms exist (#628)

ktbyers · 2018-01-21T18:57:17Z

Added two methods per @dbarrosop comment (although I changed the name of one of them). Implemented and tested them on Cisco IOS.

dbarrosop · 2018-01-22T08:34:44Z

Awesome! :)

ktbyers · 2018-01-31T04:41:28Z

@dbarrosop @mirceaulinic Did some more research and review (which also helped me remember past research):

IOS - Should be able to do reasonable system-wide solution.
NX-OS - Does not have any reasonable solution (AFAIK). The only thing I see is a kludge that we shouldn't do. This is also what I found in past research. We can ask in Cisco channel or NAPALM channel and see if anyone know of a reasonable solution, but I am not seeing one.
EOS - I think there is support, but a specific version is required. I believe I had this discussion with @bewing previously.
Junos - should be fine
IOS-XR - Can you commit-confirm in a different SSH session on IOS-XR? I wasn't seeing a good way of doing this in brief testing. @mirceaulinic

dbarrosop · 2018-02-03T18:19:23Z

We need to confirm 5. @mirceaulinic is that something you can look into?

ktbyers · 2019-04-18T22:39:03Z

Closing...don't think it makes sense to keep this PR open any longer.

ktbyers added 3 commits November 21, 2017 19:56

Add framework to support commit confirmed

56324e4

Cisco IOS proof of concept on commit confirmed

34bbc19

Adding message argument support

0b93f4f

ktbyers mentioned this pull request Nov 22, 2017

Add commit message #547

Closed

mirceaulinic requested a review from a team November 23, 2017 10:46

mirceaulinic added api change base core enhancement labels Nov 23, 2017

mirceaulinic added this to the APPROVED milestone Nov 23, 2017

Merge branch 'develop' into commit_confirmed3

eb80297

mirceaulinic reviewed Dec 15, 2017

View reviewed changes

dbarrosop reviewed Jan 2, 2018

View reviewed changes

Add new methods for immediate revert and checking if pending commit c…

b923e6f

…onfirms exist (#628)

ktbyers closed this Apr 18, 2019

rbcollins123 mentioned this pull request Feb 6, 2020

commit confirm support #1118

Open

ktbyers mentioned this pull request Sep 13, 2020

Commit-Confirm Design Spec #1292

Closed

DanSheps mentioned this pull request Oct 18, 2021

Cisco IOS - Support revert timer for both replace and merge configuration #1512

Closed

1 task

ktbyers deleted the commit_confirmed3 branch February 28, 2024 18:25

DO NOT Merge: Add commit confirmed plus commit message support #550

DO NOT Merge: Add commit confirmed plus commit message support #550

Uh oh!

Conversation

ktbyers commented Nov 22, 2017

Uh oh!

coveralls commented Nov 22, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ktbyers commented Nov 22, 2017

Uh oh!

mirceaulinic left a comment

Choose a reason for hiding this comment

Uh oh!

mirceaulinic Dec 15, 2017

Choose a reason for hiding this comment

Uh oh!

mirceaulinic Dec 15, 2017

Choose a reason for hiding this comment

Uh oh!

coveralls commented Dec 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ktbyers commented Dec 20, 2017

Uh oh!

ktbyers commented Dec 20, 2017

Uh oh!

dbarrosop Jan 2, 2018

Choose a reason for hiding this comment

Uh oh!

dbarrosop Jan 2, 2018

Choose a reason for hiding this comment

Uh oh!

ktbyers Jan 3, 2018

Choose a reason for hiding this comment

Uh oh!

sdanelli Jan 21, 2018

Choose a reason for hiding this comment

Uh oh!

dbarrosop commented Jan 2, 2018

Uh oh!

ktbyers commented Jan 21, 2018

Uh oh!

dbarrosop commented Jan 22, 2018

Uh oh!

ktbyers commented Jan 31, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dbarrosop commented Feb 3, 2018

Uh oh!

ktbyers commented Apr 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

coveralls commented Nov 22, 2017 •

edited

Loading

coveralls commented Dec 15, 2017 •

edited

Loading

ktbyers commented Jan 31, 2018 •

edited

Loading