Refactor code by move start thread fetcher to show event #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
- Coverage 94.21% 94.10% -0.11%
==========================================
Files 14 14
Lines 2228 2239 +11
==========================================
+ Hits 2099 2107 +8
- Misses 129 132 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TimMonko
changed the title
jaimergp
reviewed
Oct 15, 2025
Comment on lines
+1780
to
+1783
| if self.worker is not None and self.worker.is_running: | ||
| self.worker.terminate() | ||
| self.worker.wait() | ||
| self.worker = None |
There was a problem hiding this comment.
This will cancel ongoing tasks, right? That would go against the idea of background tasks in #174
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.