Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Texturizing Pattern: Auxiliary Notes #121

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

Alicelavander
Copy link

Adds a new texturization pattern in texturizers.py. Creates an auxiliary note from a quater note / half note long chords.

@napulen
Copy link
Owner

napulen commented May 10, 2023

Dear Arisa,

The code looks good! I need to checkout the branch and run it locally to inspect it more closely.

In the meantime, I have a request if you wish to merge your code into the official AugmentedNet codebase:

  • Can you pass your code through the black formatter?

Something like this should help you with that, if you run it from the root folder of the repository:

$ pip install black
$ python -m black --exclude "rawdata|.env" --check -l 79 .

Black is a code formatter. All of the code in the repository uses this convention and any new code is expected to also use the convention. The -l 79 applies a constrain to 79-characters per line, which makes the coded PEP8 compliant. And the excluded directories have some python code, but we only format the internal code, not the one from external dependencies.

"RomanNumeral31",
# "SecondaryDegree22",
"SecondaryDegree22",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting. Are you running your experiments with all of these classification outputs turned on? I actually think I've never done that :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants