fix: notification call before store update

narwhal-apps · Dec 1, 2022 · fbbec97 · fbbec97
1 parent d22373d
commit fbbec97
Show file tree

Hide file tree

Showing 6 changed files with 15 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.4.1
+
+### Fix
+* change order when calling notification (before store update)
+
 ## 0.4.0
 
 ### Features

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "gitbar",
   "private": true,
-  "version": "0.4.0",
+  "version": "0.4.1",
   "type": "module",
   "scripts": {
     "dev": "vite",

diff --git a/src-tauri/Cargo.lock b/src-tauri/Cargo.lock
diff --git a/src-tauri/Cargo.toml b/src-tauri/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "gitbar"
-version = "0.4.0"
+version = "0.4.1"
 description = "Github review counter"
 authors = ["mikael.kristiansson"]
 license = "MIT"

diff --git a/src-tauri/tauri.conf.json b/src-tauri/tauri.conf.json
@@ -8,7 +8,7 @@
   },
   "package": {
     "productName": "GitBar",
-    "version": "0.4.0"
+    "version": "0.4.1"
   },
   "tauri": {
     "allowlist": {

diff --git a/src/lib/github.ts b/src/lib/github.ts
@@ -31,6 +31,12 @@ const fetchReviews = async (account: AuthState) => {
   const res = await getReviews(account);
   let prevCount: number;
   github.subscribe(({ reviews }) => (prevCount = reviews.count));
+
+  if (res.issueCount > prevCount) {
+    const title = res.edges[0].node.title;
+    const author = res.edges[0].node.author.login;
+    notification(`${title} - @${author}`);
+  }
   if (res.issueCount !== prevCount) {
     github.update((prev) => ({
       ...prev,
@@ -41,12 +47,6 @@ const fetchReviews = async (account: AuthState) => {
     }));
     invoke('set_review_count', { count: String(res.issueCount) });
   }
-
-  if (res.issueCount > prevCount) {
-    const title = res.edges[0].node.title;
-    const author = res.edges[0].node.author.login;
-    notification(`${title} - @${author}`);
-  }
 };
 
 export const github = writable({