-
Notifications
You must be signed in to change notification settings - Fork 167
feat: Accept kwargs in {DataFrame,Series}.to_pandas
#2879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dangotbanned
wants to merge
97
commits into
main
Choose a base branch
from
arrow-to-pandas-dtypes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
reviewed
Jul 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this @dangotbanned , it seems reasonable to me!
Yet if we do it, I would rather keep it consistent for all the dtypes that would only be supported with ArrowDtype's. WDYT?
- Lightly adapted fromhttps://arrow.apache.org/docs/python/generated/pyarrow.Table.html#pyarrow.Table.to_pandas - Most likely, will edit it down but there's too many options + ambiguous names to not have something
Struct
dtype in pyarrow
-> pandas
(DataFrame|Series).to_pandas
No intention of supporting it there
Was causing another test to fail that expected numpy dtypes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
pa.Table.to_pandas
Β #2123Series.hist
Β #2839 (comment)pa.Table.to_pandas
Β #2123 (comment))Description
Note
Changed scope a bit from the original PR, see (#2879 (review)) and the original description for details
Show original description
Description
While I was looking into (#2839 (comment)) I noticed that the default (and only) behavior for
nw.DataFrame.to_pandas
when backed by eitherpa.Table
,pl.DataFrame
isn't great for nested datatypes:We can do better than this, and currently this PR will instead give us something that works with
pd.Series.struct
:Questions
DType
s e.g.List
?to_pandas(use_pyarrow_extension_array=...)
parameter frompolars
?i. Note that this defaults to
False
, which is equivalent to our current behavior andpyarrow
'sAdds optional keyword-only arguments to both of
DataFrame.to_pandas
,Series.to_pandas
.This aligns us with the same methods found in
polars
andpyarrow
:polars.Series.to_pandas
pyarrow.ChunkedArray.to_pandas
polars.DataFrame.to_pandas
pyarrow.Table.to_pandas
As mentioned in (#2123), this can reduce the memory overhead if configured correctly.
But, the main benefit I'm excited about is that we can preserve
pyarrow
data types (nulls, nested data) see (#2123 (comment)) - which were previously lost unconditionallyExample
Before
After
Tasks
Compliant*
signaturesCompliant*
runtime behaviorArrow(DataFrame|Series)
Polars(DataFrame|Series)
PandasLike(DataFrame|Series)
cuDF
DataFrame.to_pandas
Series.to_pandas
DataFrame.to_pandas
Series.to_pandas
pyarrow
addedTable.to_struct_array
to_struct_array
compat forpyarrow<15
polars
andpandas
as wellSeries
DataFrame
{DataFrame,Series}.to_pandas
Β #2879 (review))PandasLike
alternatives (feat: Accept kwargs in{DataFrame,Series}.to_pandas
Β #2879 (comment))