feat: Add support for {Expr,Series}.str.to_titlecase
#3116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FBruzzesi
commented
Sep 10, 2025
FBruzzesi
commented
Sep 10, 2025
FBruzzesi
commented
Sep 10, 2025
FBruzzesi
commented
Sep 10, 2025
dangotbanned
added a commit
that referenced
this pull request
Sep 11, 2025
Possibly helpful for #3116 (comment) Includes version handling via [`module.__getattr__`](https://docs.python.org/3/reference/datamodel.html#module.__getattr__) ### Note I'm not gonna push back if we explicitly **don't** want this one encouraged 😂: - #2370 - #2729
FBruzzesi
changed the title
{Expr,Series}.str.to_titlecase for non sql-like backends{Expr,Series}.str.to_titlecase
FBruzzesi
commented
Sep 11, 2025
dangotbanned
added a commit
that referenced
this pull request
Sep 12, 2025
- Towards #3116 (comment) - Typing is easy to fix
dangotbanned
added a commit
that referenced
this pull request
Sep 12, 2025
10 tasks
There was a problem hiding this comment.
Thanks @FBruzzesi - a few notes/suggestions from me - but looking good 🥳
Comment on lines
+38
to
+51
| def to_titlecase(self) -> SparkLikeExpr: | ||
| impl = self.compliant._implementation | ||
| sqlframe_required_version = (3, 43, 1) | ||
| if ( | ||
| impl.is_sqlframe() | ||
| and (version := impl._backend_version()) < sqlframe_required_version | ||
| ): # pragma: no cover | ||
| required_str = requires._unparse_version(sqlframe_required_version) | ||
| found_str = requires._unparse_version(version) | ||
| msg = ( | ||
| f"`str.to_titlecase` is only available in 'sqlframe>={required_str}', " | ||
| f"found version {found_str!r}." | ||
| ) | ||
| raise NotImplementedError(msg) |
There was a problem hiding this comment.
I guess this would be a case that #3059 would be nice for?
This'll do for now though 😄
dangotbanned
approved these changes
Oct 6, 2025
There was a problem hiding this comment.
Thanks @FBruzzesi, my suggestions aren't blocking - looking great
Co-authored-by: Dan Redding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
str.to_titlecase#3060Checklist
If you have comments or can explain your changes, please do so below