feat: Public is_eager_allowed in the Implementation class #3150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
1 task
|
Thanks for opening this PR @TheSkyentist! I see this started in (astropy/astropy#18435 (comment)). Would you be able to update #3149 with some more context please? Particularly, summarizing in the context of (astropy/astropy#18435):
FWIW, I'm not opposed to making some version of this public API. 
|
TheSkyentist
changed the title
|
Happy to do so! I've gone ahead and updated the feature request :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below
I have moved the
nw._utils.is_eager_allowedfunction as a public Implementation method.