SNEWS conversions #38
Conversation
Explicit int conversion removed MAXI_UNKNOWN conversion Removed GECAM_FLT and GECAM_GND conversion Added documentation and changed function name reformatted file deleted files
| comments = "" | ||
| comments += ( | ||
| "This is an Individual detection.\n" | ||
| if trig_id_bits[0] == 1 | ||
| else "This is an Coincidence detection.\n" | ||
| ) | ||
| comments += ( | ||
| "This is a test notice.\n" | ||
| if trig_id_bits[1] == 1 | ||
| else "This is a real notice.\n" | ||
| ) |
There was a problem hiding this comment.
By transforming the bit field to comments, we are making it less machine readable than before. Please introduce schema definitions for these fields.
There was a problem hiding this comment.
The test notice is encapsulated in 'alert_tense' so I could remove that. However, I don't think there is a schema definition of individual or coincidence detection, so I would have to define a new field. I mainly added these since the comments in the text notices had these as well.
There was a problem hiding this comment.
Please work with @Vidushi-GitHub to start defining schema where necessary to capture these fields.
There was a problem hiding this comment.
I spoke with @Vidushi-GitHub last week and we worked out a format to encode the detection quality and remove the comments. We also decided that the individual/coincidence detection was redundant and since this can be inferred from detector quality and I've left a comment in the code highlighting this
| if trig_id_bits[5] == 1: | ||
| comments += "This is definitely not a core-collapse Supernova." |
There was a problem hiding this comment.
Please capture this flag in a machine-readable way, not as a comment.
Actually if this bit is set, then the intention is to retract the alert. @Vidushi-GitHub, how do we represent a retraction?
There was a problem hiding this comment.
I can modify the 'alert_type' field for this correction.
There was a problem hiding this comment.
The following field is missing:
long 9 event_flue [counts] Number of neutrinos (0 to infinity)
There was a problem hiding this comment.
This data is stored in 'n_events'. I defined a new field since there is no equivalent in the core schema.
Binary conversion for SNEWS