Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subs to all topics, specify binary path, logic for all others as json #94

Closed
wants to merge 4 commits into from

Conversation

dakota002
Copy link
Collaborator

@dakota002 dakota002 requested a review from lpsinger June 12, 2023 13:21
Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we can consider email alerts for topics that do not belong to GCN Classic, we need to be able to emulate the Kafka topic permissions for each user. That probably means being able to programmatically manage the Kafka topic permissions.

@dakota002 dakota002 marked this pull request as draft October 26, 2023 17:32
Copy link
Member

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not safe to permit email subscriptions to any topic because not all users are supposed to have access to all topics.

@dakota002
Copy link
Collaborator Author

dakota002 commented Oct 26, 2023

Should there be multiple consumers, like per group?
Should that be determined on the email subscriptions page? So that only the topics for the groups the user is part of are available?

Or would it be better to just exclude those that people shouldn't be subscribed to?

@lpsinger
Copy link
Member

lpsinger commented Feb 5, 2024

Fixed by #162.

@lpsinger lpsinger closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants