Add record error handling to sample code #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Consumer.consume()` reports error messages by returning records with `message.error()` set. Without this error handling, the user's code is likely to raise an exception when it attempts to decode the value as if it was a normal record. See also nasa-gcn/gcn-email#116.
lpsinger
added
bug
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
=======================================
Coverage 77.04% 77.04%
=======================================
Files 7 7
Lines 122 122
=======================================
Hits 94 94
Misses 28 28 ☔ View full report in Codecov by Sentry. |
lpsinger
added a commit
to lpsinger/gcn.nasa.gov
that referenced
this pull request
Aug 20, 2023
dakota002
approved these changes
Aug 21, 2023
Vidushi-GitHub
pushed a commit
to Vidushi-GitHub/gcn.nasa.gov
that referenced
this pull request
Oct 11, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumer.consume()reports error messages by returning records withmessage.error()set. Without this error handling, the user's code is likely to raise an exception when it attempts to decode the value as if it was a normal record.See also nasa-gcn/gcn-email#116.