updates the consumer loop to put messages in the s3 bucket #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsinger
reviewed
Aug 28, 2024
There was a problem hiding this comment.
- This shouldn't go in the stats callback. It should go in the actual message receiving loop body.
- Please compare your file naming convention and data format with the official connector, https://www.confluent.io/hub/confluentinc/kafka-connect-s3.
|
Resolves 1266 |
lpsinger
requested changes
Sep 3, 2024
…use naming structure as defined on confluent docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.