42 redo sbn reintegrate #135
Conversation
|
Should the files config/sbn_cfs_config and data.telemetry_configs/adapter_TLM_CONFIG.json stay in this branch? I'm pretty sure they were used for testing sbn_adapter with cfs at one point, but I don't know where that testing was done. |
There was a problem hiding this comment.
Overall this is looking really good! I had just a few questions / nitpicks.
Can you also document how you ran this with cFS? If this is short, you can add it to the top level readme, otherwise do it in a separate doc. For cFS, can you point me to the repo you set up and I'll fork it?
Great work, thanks!
|
I copied these changes over to a setup I have for a different project, and can confirm that it functions as expected and the OnAIR results were identical with the older SBN rework I did. |
Thank you! This is the repo I used for cfs: https://github.com/williamzhang0306/cFS-OnAIR. |
|
Note that we are also including OnAir in NOS3 which includes a distribution of cFS draco-rc4 at the time of writing: We made forks for now trying to get things working:
I can add you both to the repos if you'd like to assist directly there and collaborate more closely! |
There was a problem hiding this comment.
This is great work! I tried out the instructions and they worked flawlessly on my machine. Thanks!
Just a few small tweaks, and I want @asgibson to have a chance to review the unit tests before final approval.
| {"0x0887": ["SAMPLE", "sample_data_power_t"], | ||
| "0x0889": ["SAMPLE", "sample_data_thermal_t"], | ||
| "0x088A": ["SAMPLE", "sample_data_gps_t"] | ||
| } | ||
| } |
This branch updates the sbn_adapter data source to the current state of OnAir and including unit tests.