Fix early-callback bug in jsftp #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markdboyd
reviewed
Oct 23, 2018
| t.is(output.filesCount, 2); | ||
| t.is(output.totalSize, 3952643); | ||
| } | ||
| catch (err) { |
There was a problem hiding this comment.
Are we sure we won't need this anymore? This catch seems related to whether Localstack is up/down and not necessarily the FTP issue?
There was a problem hiding this comment.
If localstack is unavailable for some reason then that's an issue that we need to fix.
markdboyd
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue in jsftp where it can invoke the callback before the file has been completely written to disk. Fixed that issue in a fork for that repo, issued a PR to the jsftp repo, and updated our code to use the forked version until the PR is pulled into the upstream jsftp repo.
jsftp issue
PR that fixes it
Fixes CUMULUS-969