Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added CF override for the metadata bug in ATL19 in crs_txt #7

Merged
merged 3 commits into from
Apr 3, 2024
Merged

added CF override for the metadata bug in ATL19 in crs_txt #7

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4bcbcb6
added CF override for the metadata bug in ATL19 in crs_txt
sudha-murthy Mar 29, 2024
21755cf
added version update
sudha-murthy Mar 29, 2024
e413304
updates made based on PR feedback
sudha-murthy Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits with this description:

  • The issue is sort of a leading backslash, but really it's a leading speech mark that is escaped by a backslash.
  • There's a stray blank line at the top of the file (that shouldn't affect the CI/CD trying to create the release notes, but I'd get rid of it just to be safe).
  • This causes the errors, maybe instead: This causes errors.
  • There's a missing full stop at the end of the paragraph.

I don't think any of these are showstoppers. Just me being a bit pedantic. (I tested the bin/extract-release-notes.sh script with a blank line at the top of CHANGELOG.md and it worked, but had the blank line that might look a bit odd)

## v1.0.3
### 2024-3-29

This version of HOSS handles the error in the crs_wkt attribute in ATL19 where the
north polar crs variable has a leading slash in the crs_wkt attribute. This causes
the errors when the projection is being interpreted from the crs variable attributes

## v1.0.2
### 2024-2-26

Expand Down
2 changes: 1 addition & 1 deletion docker/service_version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.0.2
1.0.3
14 changes: 14 additions & 0 deletions hoss/hoss_config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,20 @@
],
"_Description": "ATL16 has edge-aligned grid cells."
},
{
"Applicability": {
"Mission": "ICESat2",
"ShortNamePath": "ATL19",
"Variable_Pattern": "/north_polar/crs"
},
"Attributes": [
{
"Name": "crs_wkt",
"Value": "PROJCS[\"NSIDC Sea Ice Polar Stereographic North\",GEOGCS[\"Unspecified datum based upon the Hughes 1980 ellipsoid\",DATUM[\"Not_specified_based_on_Hughes_1980_ellipsoid\",SPHEROID[\"Hughes 1980\",6378273,298.279411123061,AUTHORITY[\"EPSG\",\"7058\"]],AUTHORITY[\"EPSG\",\"6054\"]],PRIMEM[\"Greenwich\",0,AUTHORITY[\"EPSG\",\"8901\"]],UNIT[\"degree\",0.0174532925199433,AUTHORITY[\"EPSG\",\"9122\"]],AUTHORITY[\"EPSG\",\"4054\"]],PROJECTION[\"Polar_Stereographic\"],PARAMETER[\"latitude_of_origin\",70],PARAMETER[\"central_meridian\",-45],PARAMETER[\"scale_factor\",1],PARAMETER[\"false_easting\",0],PARAMETER[\"false_northing\",0],UNIT[\"metre\",1,AUTHORITY[\"EPSG\",\"9001\"]],AXIS[\"X\",EAST],AXIS[\"Y\",NORTH],AUTHORITY[\"EPSG\",\"3411\"]]"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This looks a bit clunky, because the value of the metadata attribute it looooong, but I think this is a good fix. When the collection is fixed up, we'll be able to remove this anyway and clean up the file.

],
"_Description": "Remove leading slash in ATL19 for crs_wkt attribute"
},
{
"Applicability": {
"Mission": "ICESat2",
Expand Down
Loading