Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP-241 - Implement pre-commit CI/CD. #8

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

owenlittlejohns
Copy link
Member

@owenlittlejohns owenlittlejohns commented Apr 11, 2024

Description

This PR is to add pre-commit.ci to HOSS, which will automatically run our pre-commit hooks for each PR. I've configured it to not automatically add a new commit with the changes, because it feels better to still have a human in the loop to review those changes.

Steps to set this up:

  1. Log in to pre-commit.ci.
  2. Select repositories for which I (or the person doing this) is an administrator, and add them to pre-commit.ci.
  3. Update the .pre-commit-config.yaml to add the ci section.
  4. Feel pleased about life.

When the PR was initially written, I purposefully added some erroneous whitespace into the README, so that it should fail the check. I'll fix that and then squash-and-merge when the PR is approved.

Jira Issue ID

N/A

Local Test Steps

N/A

PR Acceptance Checklist

  • Jira ticket acceptance criteria met.
  • CHANGELOG.md updated to include high level summary of PR changes.
  • docker/service_version.txt updated if publishing a release.
  • Tests added/updated and passing.
  • Documentation updated (if needed).

@owenlittlejohns owenlittlejohns marked this pull request as ready for review April 11, 2024 22:06
Copy link
Member

@flamingbear flamingbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do it! :shipit:

@owenlittlejohns owenlittlejohns merged commit 71414d3 into nasa:main Apr 11, 2024
4 checks passed
@owenlittlejohns owenlittlejohns deleted the IP-241-pre-commit-cicd branch April 11, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants