IP-241 - Implement pre-commit CI/CD. #8
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to add pre-commit.ci to HOSS, which will automatically run our
pre-commit
hooks for each PR. I've configured it to not automatically add a new commit with the changes, because it feels better to still have a human in the loop to review those changes.Steps to set this up:
pre-commit.ci
..pre-commit-config.yaml
to add theci
section.When the PR was initially written, I purposefully added some erroneous whitespace into the README, so that it should fail the check. I'll fix that and then squash-and-merge when the PR is approved.
Jira Issue ID
N/A
Local Test Steps
N/A
PR Acceptance Checklist
Jira ticket acceptance criteria met.CHANGELOG.md
updated to include high level summary of PR changes.docker/service_version.txt
updated if publishing a release.Tests added/updated and passing.