CI Benchmarking - #178
Draft
cole-wilson wants to merge 27 commits into
Draft
Conversation
cole-wilson
marked this pull request as ready for review
August 22, 2026 01:05
cole-wilson
marked this pull request as draft
August 22, 2026 01:53
…nto benchmark_final
Code Coverage ReportCurrent Coverage: 95.37% |
h313
reviewed
Aug 23, 2026
| } | ||
|
|
||
| pub fn clock_get_ms() -> i64 { | ||
| std::time::SystemTime::now() |
Collaborator
There was a problem hiding this comment.
You might want to be careful with using SystemTime, since it becomes a Linux syscall. There's some overhead there that you might not be able to ignore, depending on how long the tests take. It's better to use native CPU performance counters to read clocks / instructions processed instead.
Collaborator
Author
There was a problem hiding this comment.
Okay I will look into it, thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WORK IN PROGRESS
making this draft PR early so the workflows run