Skip to content

Clean up code-base from external review - #189

Open
Kronos3 wants to merge 2 commits into
mainfrom
cleanup
Open

Clean up code-base from external review#189
Kronos3 wants to merge 2 commits into
mainfrom
cleanup

Conversation

@Kronos3

@Kronos3 Kronos3 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

There aren't any breaking API changes here, just correctness and maintenance cleanups we found when reviewing the code-base.

@github-actions

github-actions Bot commented Aug 31, 2026

Copy link
Copy Markdown

CoreMark Benchmark Results

Current Score: 236.500
Baseline Score (main): 241.371
Difference: -4.871 (-2.02%)

@github-actions

Copy link
Copy Markdown

Code Coverage Report

Current Coverage: 95.50%
Baseline Coverage (main): 95.50%
Difference: -0.01%

@sylvesterkaczmarek sylvesterkaczmarek left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new try_new() path propagates Box::new(f) allocation failure, but get_call() still allocates Box::new(placeholder).unwrap() on every invocation. Under a fallible/custom allocator that can still panic at runtime after construction succeeded. Could the placeholder be allocation-free/preallocated, or can get_call() propagate AllocError too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants