-
Notifications
You must be signed in to change notification settings - Fork 22
Add M1 support to build #90
base: master
Are you sure you want to change the base?
Conversation
Lowest version that Lavalink will run under. Co-authored-by: aikaterna <[email protected]> Co-authored-by: Jakub Kuczys <[email protected]>
`withArguments` deals with already split arguments, so arguments with spaces are passed as a single argument
This is blocked by the native lib loader not supporting mac m1, Per tests by @aikaterna loading natives on mac m1 would load the avx2 one, as aarch64 does not contain support for avx2 it will crash. The issue to my understanding the upstream library cpu_features for native lib detector does not support m1. The support is pending on the upstream library, see natanbc/native-loader#1. A solution would be to do something smilar to , https://github.com/aikaterna/lavadsp/blob/f6fce3c9d3c630a77061780f2902c551416c5a12/src/main/java/com/github/natanbc/lavadsp/natives/TimescaleNativeLibLoader.java#L35. The solution above is tested and works. |
Started working on a rewrite of native-loader, which will also support M1 https://github.com/natanbc/native-loader/tree/native-rewrite |
Depends on #88, thanks @Walkyst for your work there!
This adds M1 as a target compilation from x86_x64 mac runner, in addition min deployment target with the default XCode supplied is 10.12.6, as Lavalink will only run on 10.12, re @aikaterna.
Thanks to @aikaterna and @jack1142 for assisting with this PR.
Some improvements, we could ditch Java 15 and use the built-in Github runner java versions https://github.com/actions/runner-images/blob/main/images/macos/macos-11-Readme.md#java but it's not really needed, unless you want me to do that @natanbc
TODO: