Prefer and Indicate Explicit Albums/Tracks #807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prefer_explicit parameter should have been set when calling _filter_repeats.
There is a silly mistake in the repeat album filter that causes all albums to be filtered out, if repeats_prefer_explicit is set to True. It fails to check if all albums in the group are not explicit, which is very common because most albums are not explicit. This commit fixes that by only filtering out the non-explicit albums, if there is at least one explicit album in the group.
|
I think we should just prefer explicit by default, since that's usually the original track. No need for config changes. |
|
Closed by 1bf4e68 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #799 and close #685.