-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core and Platforms - Updated for latest libnx and fixed compile error #168
base: main
Are you sure you want to change the base?
Conversation
(for the record, my PR is for the legacy branch) |
Thanks for the PR! Why change the optional include? I'm not fan of changing
external code like that
Le 11 août 2021 09:53:07 Pablo Curiel ***@***.***> a écrit :
…
(for the record, my PR is for the legacy branch)
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
|
I think I took it from somewhere else, I'll revert the change and put the optional header on top of the <nanovg/dk_renderer.hpp> header. |
Actually, that doesn't fix it. If you compile the code, you'll get this error: In file included from /Users/emreterzioglu/Documents/C++_Programs/borealis-fork/working-yoga/./library/lib/extern/nanovg-deko3d/source/dk_renderer.cpp:1:
/Users/emreterzioglu/Documents/C++_Programs/borealis-fork/working-yoga/./library/lib/extern/nanovg-deko3d/include/nanovg/dk_renderer.hpp:168:18:
error: 'optional' in namespace 'std' does not name a template type
168 | std::optional<CMemPool::Handle> m_vertex_buffer;
| ^~~~~~~~ This means the optional include has to be moved into the |
I decided to open an issue in the |
Alright, so a fix was merged into |
subrepo: subdir: "library/lib/extern/nanovg-deko3d" merged: "5b8661b" upstream: origin: "https://github.com/Adubbz/nanovg-deko3d" branch: "master" commit: "bb69eb5" git-subrepo: version: "0.4.3" origin: "https://github.com/ingydotnet/git-subrepo" commit: "2f68596"
Any plans to merge the fix? Compile error still present and I'm not able to include as a submodule because of it |
I'm awaiting review from @natinusala |
This is identical to #164 except an additional compile error was fixed.