Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core and Platforms - Updated for latest libnx and fixed compile error #168

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

EmmmaTech
Copy link
Contributor

This is identical to #164 except an additional compile error was fixed.

@DarkMatterCore
Copy link

(for the record, my PR is for the legacy branch)

@natinusala
Copy link
Owner

natinusala commented Aug 11, 2021 via email

@EmmmaTech
Copy link
Contributor Author

I think I took it from somewhere else, I'll revert the change and put the optional header on top of the <nanovg/dk_renderer.hpp> header.

@EmmmaTech
Copy link
Contributor Author

Actually, that doesn't fix it. If you compile the code, you'll get this error:

In file included from /Users/emreterzioglu/Documents/C++_Programs/borealis-fork/working-yoga/./library/lib/extern/nanovg-deko3d/source/dk_renderer.cpp:1:
/Users/emreterzioglu/Documents/C++_Programs/borealis-fork/working-yoga/./library/lib/extern/nanovg-deko3d/include/nanovg/dk_renderer.hpp:168:18: 
error: 'optional' in namespace 'std' does not name a template type
  168 |             std::optional<CMemPool::Handle> m_vertex_buffer;
      |                  ^~~~~~~~

This means the optional include has to be moved into the dk_renderer.hpp file.

@EmmmaTech
Copy link
Contributor Author

I decided to open an issue in the nanovg-deko3d repo about this compiler error.

@EmmmaTech
Copy link
Contributor Author

Alright, so a fix was merged into nanovg-deko3d, so I can pull the change

subrepo:
  subdir:   "library/lib/extern/nanovg-deko3d"
  merged:   "5b8661b"
upstream:
  origin:   "https://github.com/Adubbz/nanovg-deko3d"
  branch:   "master"
  commit:   "bb69eb5"
git-subrepo:
  version:  "0.4.3"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "2f68596"
@EmmmaTech EmmmaTech changed the title ASAP Merge - Updated for latest libnx and fixed compile error Core and Platforms - Updated for latest libnx and fixed compile error Nov 4, 2021
@JSH32
Copy link

JSH32 commented Apr 7, 2022

Any plans to merge the fix? Compile error still present and I'm not able to include as a submodule because of it

@EmmmaTech
Copy link
Contributor Author

I'm awaiting review from @natinusala
They have been inactive in this repo, so PRs aren't really being reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants